Merged
Conversation
There was a problem hiding this comment.
Hey @robbycochran - I've reviewed your changes - here's some feedback:
Overall Comments:
- This revert removes ARM from the unit test matrix; confirm if this is the intended behavior.
- Building ARM images on amd64 runners using emulation might significantly increase build times compared to using native ARM runners.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
JoukoVirtanen
approved these changes
Apr 26, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #2107 +/- ##
=======================================
Coverage 28.40% 28.40%
=======================================
Files 94 94
Lines 5717 5717
Branches 2531 2531
=======================================
Hits 1624 1624
Misses 3383 3383
Partials 710 710
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
robbycochran
added a commit
that referenced
this pull request
Apr 28, 2025
This reverts commit 61cd323.
robbycochran
added a commit
that referenced
this pull request
May 20, 2025
This reverts commit 61cd323.
robbycochran
added a commit
that referenced
this pull request
May 23, 2025
Molter73
pushed a commit
that referenced
this pull request
Jul 15, 2025
Molter73
added a commit
that referenced
this pull request
Jul 18, 2025
* ROX-29116: (fix) Use ARM GH action workflow runners for ARM builds (#2106) * Revert "Revert GH arm changes (#2107)" * Add arm64 stable, beta, and dev channels for Google COS integration tests (#2096) * Use P and Z GHA runners (#2215) * Use go cross-compilation to speed up test builds on CI (#2210) After adding Arm runners on GHA, we made it so the Arm test image is always built. Unfortunately, because we use QEMU to build the images, the build has gotten quite slow. In order to speed up the build, this change makes it so we cross-compile the binaries for all our supported platforms locally and the image build simply copies the binaries into the final image. --------- Co-authored-by: Robby Cochran <rcochran@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
exclude for ppc64le isn't working from #2084
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why you did not do so. (Valid reasons include "CI is sufficient" or "No testable changes")
In addition to reviewing your code, reviewers must also review your testing instructions, and make sure they are sufficient.
For more details, ref the Confluence page about this section.