Add series tool in query builder#4952
Conversation
|
This is the second component of #4804 |
|
FYI: backend, after #4929, will support server-side record cloning |
There was a problem hiding this comment.
- verify series checkbox is present only when Cat num is one of the field
- verify Distinct is read only
- Verify you can check Distinct and that Series become readonly
- Verify that all the records that have the same data for each field in your query and that have consecutive cat num are group together
- Verify that the consecutive cat numbers are displayed as a range
Looks good! This PR is working as expected.
Areyes42
left a comment
There was a problem hiding this comment.
- verify series checkbox is present only when Cat num is one of the field
- verify Distinct is read only
- Verify you can check Distinct and that Series become readonly
- Verify that all the records that have the same data for each field in your query and that have consecutive cat num are group together
- Verify that the consecutive cat numbers are displayed as a range
Everything looks good for the most part! I noticed that a TypeError occurs if you run a query using series, but have the catalog number disabled in the results.
Screen.Recording.2025-04-30.at.12.57.37.PM.mov
|
@CarolineDenis I think we need to hide the series button in the QB if the user hides the Catalog Number from the results. This should fix the issue encountered by @Areyes42 I have a solution that I can commit that will only run the series query logic if the Catalog Number field sets its display value to true. But, from the user side, I think if would be better to just not allow the user to request a series query with the Catalog Number display set to false. |
Areyes42
left a comment
There was a problem hiding this comment.
- verify series checkbox is present only when Cat num is one of the field
- verify Distinct is read only
- Verify you can check Distinct and that Series become readonly
- Verify that all the records that have the same data for each field in your query and that have consecutive cat num are group together
- Verify that the consecutive cat numbers are displayed as a range
Re-running the same query I mentioned earlier now throws an IndexErrorwhenever the formatted field is included. I’ve tried replicating the issue on other databases, but it only seems to occur in ciscollections. Also, the series button no longer appears when the catalog number is excluded from the results ✅.
|
@Areyes42 @specify/ux-testing Pushed a fix for the series QB that was found on ciscollections. Ready for retesting on that DB, thanks! |
Areyes42
left a comment
There was a problem hiding this comment.
- verify series checkbox is present only when Cat num is one of the field
- verify Distinct is read only
- Verify you can check Distinct and that Series become readonly
- Verify that all the records that have the same data for each field in your query and that have consecutive cat num are group together
- Verify that the consecutive cat numbers are displayed as a range
Looks good!
Fixes #2000
Fixes #6166
Checklist
and self-explanatory (or properly documented)
Testing instructions
Tips:
With Series

Without Series

NOTES:
Sorting the column cat num is not available for series