Add bulk carry forward feature#4804
Merged
Merged
Conversation
Triggered by 0680b87 on branch refs/heads/issue-545
CarolineDenis
force-pushed
the
issue-545
branch
from
April 23, 2024 16:20
ffa931c to
5cf1c90
Compare
sharadsw
approved these changes
May 21, 2024
sharadsw
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me! Only making some optional suggestions
maxpatiiuk
requested changes
May 27, 2024
melton-jason
self-requested a review
July 8, 2024 19:10
maxpatiiuk
approved these changes
Jul 9, 2024
Areyes42
self-requested a review
July 9, 2024 16:37
Areyes42
suggested changes
Jul 9, 2024
Areyes42
left a comment
Contributor
There was a problem hiding this comment.
Testing instructions
- Create a new CO
- Save
- Go in the form meta, check the box "Show Bulk Carry Forward count"
- Verify the box "Show Bulk Carry Forward count" is displayed only when carry forward is checked
- Verify that the Bulk amount input is not displayed on the form if carry forward or "Show Bulk Carry Forward count" is not checked in the form meta
- Go back to the CO form
- Enter the amount you want to bulk carry
- Click on carry forward
- Verify that a new RS is created
- Verify that the new RS has, as a title, the cat number range
- Verify once the new RS is created, it opens it
I tested this PR yesterday and it was working fine. It's now throwing a TypeError when trying to bulk carry. Tested on multiple COs and DBs.
Specify 7 Crash Report - 2024-07-09T16_28_03.361Z.txt
Screen.Recording.2024-07-09.at.11.27.28.AM.mov
Areyes42
approved these changes
Jul 9, 2024
Areyes42
left a comment
Contributor
There was a problem hiding this comment.
Testing instructions
- Create a new CO
- Save
- Go in the form meta, check the box "Show Bulk Carry Forward count"
- Verify the box "Show Bulk Carry Forward count" is displayed only when carry forward is checked
- Verify that the Bulk amount input is not displayed on the form if carry forward or "Show Bulk Carry Forward count" is not checked in the form meta
- Go back to the CO form
- Enter the amount you want to bulk carry
- Click on carry forward
- Verify that a new RS is created
- Verify that the new RS has, as a title, the cat number range
- Verify once the new RS is created, it opens it
Retested, everything looks good!
melton-jason
previously requested changes
Jul 9, 2024
Co-authored-by: Jason Melton <64045831+melton-jason@users.noreply.github.com>
realVinayak
previously requested changes
Jul 15, 2024
7 tasks
Member
|
Need to now implement #4952 |
|
This pull request has been mentioned on Specify Community Forum. There might be relevant details there: https://discourse.specifysoftware.org/t/specify-7-9-7-release-announcement/1979/1 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #545
Checklist
and self-explanatory (or properly documented)
Testing instructions