[Scenes] Update TriangleSurfaceCutting scene to use a bigger mesh with texture#2381
Merged
fredroy merged 5 commits intosofa-framework:masterfrom Oct 13, 2021
Merged
Conversation
Collaborator
|
[ci-depends-on] detected during build #1. To unlock the merge button, you must
|
Contributor
Author
|
[ci-build][with-all-tests] |
Collaborator
|
[ci-depends-on] detected during build #2. To unlock the merge button, you must
|
Collaborator
|
[ci-depends-on] detected during build #3. To unlock the merge button, you must
|
Collaborator
|
[ci-depends-on] detected during build #4. To unlock the merge button, you must
|
hugtalbot
reviewed
Oct 12, 2021
| <DiagonalMass massDensity="0.15" /> | ||
| <FixedConstraint indices="0 1" /> | ||
| <DiagonalMass massDensity="0.08" /> | ||
| <FixedConstraint indices="617 618 57 1301 1302 49" /> |
Contributor
There was a problem hiding this comment.
I guess that for stability purposes you are not fixing only the corners but the few points close to the corner on the top edge? Is it correct @epernod ?
epernod
added a commit
to epernod/sofa
that referenced
this pull request
Oct 14, 2021
…h texture (sofa-framework#2381) * [scenes] Update TriangleSurfaceCutting to use a bigger mesh with texture * [scenes] Fix remove texturename * Fix spacing * Restore colormap * fix indent problem
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the PR #2300 here is a new version of the scene TriangleSurfaceCutting.scn with a texture. See picture in PR #2300
For the Regression program I had to add in the scene:
CImgPlugin as requiredPlugin to be able to use this line:
<OglModel name="Visual" texcoords="@../meshLoader.texcoords" texturename="textures/colorMap.png" />[ci-depends-on https://github.com/sofa-framework/Regression/pull/19]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if