Skip to content

[Scenes] Update TriangleSurfaceCutting scene to use a bigger mesh with texture#2381

Merged
fredroy merged 5 commits intosofa-framework:masterfrom
epernod:inf_tiangleSurface_scene
Oct 13, 2021
Merged

[Scenes] Update TriangleSurfaceCutting scene to use a bigger mesh with texture#2381
fredroy merged 5 commits intosofa-framework:masterfrom
epernod:inf_tiangleSurface_scene

Conversation

@epernod
Copy link
Copy Markdown
Contributor

@epernod epernod commented Oct 4, 2021

Following the PR #2300 here is a new version of the scene TriangleSurfaceCutting.scn with a texture. See picture in PR #2300

For the Regression program I had to add in the scene:
CImgPlugin as requiredPlugin to be able to use this line:
<OglModel name="Visual" texcoords="@../meshLoader.texcoords" texturename="textures/colorMap.png" />

[ci-depends-on https://github.com/sofa-framework/Regression/pull/19]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@epernod epernod added the pr: status to review To notify reviewers to review this pull-request label Oct 4, 2021
@epernod epernod self-assigned this Oct 4, 2021
@sofabot
Copy link
Copy Markdown
Collaborator

sofabot commented Oct 4, 2021

[ci-depends-on] detected during build #1.

To unlock the merge button, you must

@epernod
Copy link
Copy Markdown
Contributor Author

epernod commented Oct 5, 2021

[ci-build][with-all-tests]

@sofabot
Copy link
Copy Markdown
Collaborator

sofabot commented Oct 5, 2021

[ci-depends-on] detected during build #2.

To unlock the merge button, you must

@sofabot
Copy link
Copy Markdown
Collaborator

sofabot commented Oct 6, 2021

[ci-depends-on] detected during build #3.

To unlock the merge button, you must

@sofabot
Copy link
Copy Markdown
Collaborator

sofabot commented Oct 7, 2021

[ci-depends-on] detected during build #4.

To unlock the merge button, you must

<DiagonalMass massDensity="0.15" />
<FixedConstraint indices="0 1" />
<DiagonalMass massDensity="0.08" />
<FixedConstraint indices="617 618 57 1301 1302 49" />
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that for stability purposes you are not fixing only the corners but the few points close to the corner on the top edge? Is it correct @epernod ?

@guparan guparan added the pr: enhancement About a possible enhancement label Oct 13, 2021
@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Oct 13, 2021
@fredroy fredroy merged commit aacefa1 into sofa-framework:master Oct 13, 2021
epernod added a commit to epernod/sofa that referenced this pull request Oct 14, 2021
…h texture (sofa-framework#2381)

* [scenes] Update TriangleSurfaceCutting to use a bigger mesh with texture

* [scenes] Fix remove texturename

* Fix spacing

* Restore colormap

* fix indent problem
@epernod epernod deleted the inf_tiangleSurface_scene branch October 31, 2021 14:39
@guparan guparan added this to the v21.12 milestone Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: enhancement About a possible enhancement pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants