Skip to content

[SofaBaseVisual] Fix VisualModelImpl to use topologyData and callback to handle topological changes#2300

Merged
fredroy merged 5 commits intosofa-framework:masterfrom
epernod:inf_visualModel_topo
Oct 3, 2021
Merged

[SofaBaseVisual] Fix VisualModelImpl to use topologyData and callback to handle topological changes#2300
fredroy merged 5 commits intosofa-framework:masterfrom
epernod:inf_visualModel_topo

Conversation

@epernod
Copy link
Copy Markdown
Contributor

@epernod epernod commented Aug 18, 2021 •
edited
Loading

This PR depends on PR #2299 (should be rebased)

  1. Use callback to update the list of triangles/quads and vertices when topological changes happened.
  2. Add also callback on texcoord to update texture coordinate when mesh changed.
  • Update of texture coordinates was buggy when removing points

  • Adding new points where created with texCoord(0, 0)

-> Using the callback on texcoords, use ancestors and coefficient of added point to apply the good texCoords

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@epernod epernod added pr: enhancement About a possible enhancement pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request labels Aug 18, 2021
@epernod epernod self-assigned this Aug 18, 2021
@epernod epernod added the pr: do not squash To merge instead of squash a pull-request label Aug 18, 2021
@fredroy fredroy added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Aug 25, 2021
@hugtalbot
Copy link
Copy Markdown
Contributor

hugtalbot commented Aug 25, 2021

Missing the include of an *.inl
wait for #2299 anyway

@epernod epernod force-pushed the inf_visualModel_topo branch from cb2463c to b4b3028 Compare September 9, 2021 07:51
@epernod epernod added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Sep 9, 2021
@epernod epernod force-pushed the inf_visualModel_topo branch from b4b3028 to cac40a0 Compare September 12, 2021 21:45
@epernod epernod added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Sep 22, 2021
@epernod epernod force-pushed the inf_visualModel_topo branch from d1619f2 to 26b5a93 Compare September 22, 2021 09:08
@epernod epernod added pr: status to review To notify reviewers to review this pull-request pr: status wip Development in the pull-request is still in progress and removed pr: status wip Development in the pull-request is still in progress pr: status to review To notify reviewers to review this pull-request labels Sep 23, 2021
@epernod
Copy link
Copy Markdown
Contributor Author

epernod commented Sep 27, 2021

This PR is now including a fix pushed in PR #2359 . Waiting for this new PR approval first.

@epernod
Copy link
Copy Markdown
Contributor Author

epernod commented Sep 27, 2021

[ci-build][with-all-tests]

@epernod epernod mentioned this pull request Sep 28, 2021
Open
@epernod epernod force-pushed the inf_visualModel_topo branch from 45cdf57 to 7307300 Compare September 29, 2021 14:37
@epernod epernod added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Sep 29, 2021
@epernod
Copy link
Copy Markdown
Contributor Author

epernod commented Sep 29, 2021

[ci-build][with-all-tests]

@epernod
[SofaBaseVisual] update triangles and quads callbacks to store direty…
9df8ef2 
… element from topology event. Those elements are updated at next updateVisual. This avoid too many computation in callback and also avoid to update the whole triangles/quads buffer at each new event.
@epernod epernod force-pushed the inf_visualModel_topo branch from 7d87a2d to 0e23412 Compare September 30, 2021 21:58
@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Oct 1, 2021
@fredroy fredroy merged commit bf25fdb into sofa-framework:master Oct 3, 2021
@epernod epernod mentioned this pull request Oct 4, 2021
Merged
@hugtalbot hugtalbot mentioned this pull request Oct 9, 2021
Closed
@hugtalbot hugtalbot mentioned this pull request Oct 21, 2021
Merged
@epernod epernod deleted the inf_visualModel_topo branch October 31, 2021 19:20
@guparan guparan added this to the v21.12 milestone Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fredroy fredroy fredroy approved these changes

Assignees

@epernod epernod

Labels

pr: do not squash To merge instead of squash a pull-request pr: enhancement About a possible enhancement pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Milestone

v21.12

Development

Successfully merging this pull request may close these issues.

4 participants

@epernod @hugtalbot @fredroy @guparan