implement -Zllvm-target-feature by RalfJung · Pull Request #160457 · rust-lang/rust

RalfJung · 2026-08-03T18:00:36Z

Implements #157753

rustbot · 2026-08-03T18:00:41Z

rustbot has assigned @folkertdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 75 candidates
Random selection from 19 candidates

folkertdev

Some comment nits, r=me when resolved to your satisfaction

View changes since this review

RalfJung · 2026-08-03T20:26:22Z

@folkertdev sorry I had missed your review and have done a bit more clarification on the comment about only_base_features, and also renamed that variable. I can undo that if you prefer, or could you take another look?

folkertdev

No problem, r=me when CI is green

View changes since this review

RalfJung · 2026-08-03T21:55:51Z

@GuillaumeGomez @antoyo any idea why GCC complains about retain now...?

antoyo · 2026-08-03T21:56:42Z

There was an issue in the last sync. The PR is currently being reverted.

RalfJung · 2026-08-03T21:57:00Z

Oh it did the same in #160372 (comment).
Seems like something broke about that job and now all PR CI fails? How is that even possible?

antoyo · 2026-08-03T21:57:32Z

Seems like something broke about that job and now all PR CI fails? How is that even possible?

That's something we'd like to know: how can the tests pass in PR, then fails afterwards?

RalfJung · 2026-08-04T05:46:46Z

@bors r=folkertdev

rust-bors · 2026-08-04T05:46:49Z

📌 Commit dcab1e0 has been approved by folkertdev

It is now in the queue for this repository.

rustbot · 2026-08-04T09:26:08Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

rust-bors · 2026-08-04T09:26:08Z

⚠️ A new commit c82207c46e5cefe4ddb000232aec281c28f0f6a8 was pushed.

This pull request was unapproved.

RalfJung · 2026-08-04T09:35:48Z

I just rebased to get clean PR CI.
@bors r=folkertdev

rust-bors · 2026-08-04T09:35:51Z

📌 Commit c82207c has been approved by folkertdev

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 10. This pull request will be tested once the tree is reopened.

Reason for tree closure: manually handling queue due to backlog

…lkertdev implement -Zllvm-target-feature Implements rust-lang#157753

…uwer Rollup of 22 pull requests Successful merges: - #160426 (`rust-analyzer` subtree update) - #160372 (Derive the allocator used by tools from rustc's allocator) - #146882 (fully deprecate the legacy integral modules) - #158727 (std: use `readdir` on nearly all UNIX platforms) - #159727 (Various steps in moving away from the big reflection enum to reflection functions) - #160443 (normalize in relations, not generalize, when relating infer with alias) - #160457 (implement -Zllvm-target-feature) - #160480 (Single-pass ASCII lower/upper case conversion) - #160502 (Reduce number of miri tests executed on PR CI) - #157430 (std::random: use little-endian for reproducibility) - #158110 (fix macro attribute feature-gate span) - #159975 (Use real ThinVec in StmtDebugInfos) - #160001 (Suggest mutable method when iterating over binding) - #160024 (Fix mono reachability with no-op landing pads) - #160154 (Add regression test for HRTB associated type projection closure) - #160176 (No more `tests/ui/issues`!) - #160326 (Remove hidden_glob_reexports) - #160407 (Add regression tests for a number of ICEs and diagnostics issues labelled `E-needs-test`) - #160430 (bootstrap: Don't produce mutated/filtered PathSets during command-line matching) - #160472 (Minor fixes to `core::io` & `alloc::io` Documentation) - #160486 (Remove unused `FreeRegionsVisitor`) - #160496 (clarify non-determinism docs for algebraic operations) Failed merges: - #160501 (Add bootstrap CLI snapshot test for testing miri)

Rollup merge of #160457 - RalfJung:llvm-target-feature, r=folkertdev implement -Zllvm-target-feature Implements #157753

…uwer Rollup of 22 pull requests Successful merges: - rust-lang/rust#160426 (`rust-analyzer` subtree update) - rust-lang/rust#160372 (Derive the allocator used by tools from rustc's allocator) - rust-lang/rust#146882 (fully deprecate the legacy integral modules) - rust-lang/rust#158727 (std: use `readdir` on nearly all UNIX platforms) - rust-lang/rust#159727 (Various steps in moving away from the big reflection enum to reflection functions) - rust-lang/rust#160443 (normalize in relations, not generalize, when relating infer with alias) - rust-lang/rust#160457 (implement -Zllvm-target-feature) - rust-lang/rust#160480 (Single-pass ASCII lower/upper case conversion) - rust-lang/rust#160502 (Reduce number of miri tests executed on PR CI) - rust-lang/rust#157430 (std::random: use little-endian for reproducibility) - rust-lang/rust#158110 (fix macro attribute feature-gate span) - rust-lang/rust#159975 (Use real ThinVec in StmtDebugInfos) - rust-lang/rust#160001 (Suggest mutable method when iterating over binding) - rust-lang/rust#160024 (Fix mono reachability with no-op landing pads) - rust-lang/rust#160154 (Add regression test for HRTB associated type projection closure) - rust-lang/rust#160176 (No more `tests/ui/issues`!) - rust-lang/rust#160326 (Remove hidden_glob_reexports) - rust-lang/rust#160407 (Add regression tests for a number of ICEs and diagnostics issues labelled `E-needs-test`) - rust-lang/rust#160430 (bootstrap: Don't produce mutated/filtered PathSets during command-line matching) - rust-lang/rust#160472 (Minor fixes to `core::io` & `alloc::io` Documentation) - rust-lang/rust#160486 (Remove unused `FreeRegionsVisitor`) - rust-lang/rust#160496 (clarify non-determinism docs for algebraic operations) Failed merges: - rust-lang/rust#160501 (Add bootstrap CLI snapshot test for testing miri)

rustbot assigned folkertdev Aug 3, 2026

RalfJung mentioned this pull request Aug 3, 2026

Add -Zllvm-target-feature to pass features directly to LLVM #159545

Draft

This comment has been minimized.

Sign in to view

RalfJung force-pushed the llvm-target-feature branch from 4e5c003 to 7da31f0 Compare August 3, 2026 18:12

ojeda mentioned this pull request Aug 3, 2026

Rust unstable features needed for the kernel Rust-for-Linux/linux#2

Open

52 tasks

folkertdev reviewed Aug 3, 2026

View reviewed changes

Comment thread compiler/rustc_codegen_llvm/src/llvm_util.rs Outdated

Comment thread compiler/rustc_session/src/options.rs Outdated

RalfJung force-pushed the llvm-target-feature branch 2 times, most recently from 1edb5a0 to 2df3a43 Compare August 3, 2026 20:13

This comment has been minimized.

Sign in to view

RalfJung force-pushed the llvm-target-feature branch 2 times, most recently from 46ca706 to dcab1e0 Compare August 3, 2026 20:26

folkertdev approved these changes Aug 3, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2026

RalfJung added 2 commits August 4, 2026 11:25

implement -Zllvm-target-feature

08a1b42

improve error message on missing target feature prefix

c82207c

RalfJung force-pushed the llvm-target-feature branch from dcab1e0 to c82207c Compare August 4, 2026 09:26

rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 4, 2026

rust-bors Bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 4, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 4, 2026

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 4, 2026

Rollup merge of rust-lang#160457 - RalfJung:llvm-target-feature, r=fo…

75fad49

…lkertdev implement -Zllvm-target-feature Implements rust-lang#157753

This was referenced Aug 4, 2026

Rollup of 14 pull requests #160507

Closed

Rollup of 22 pull requests #160517

Merged

rust-bors Bot merged commit 4182867 into rust-lang:main Aug 5, 2026
13 checks passed

rustbot added this to the 1.99.0 milestone Aug 5, 2026

rust-timer added a commit that referenced this pull request Aug 5, 2026

Unrolled build for #160457

bf72936

Rollup merge of #160457 - RalfJung:llvm-target-feature, r=folkertdev implement -Zllvm-target-feature Implements #157753

RalfJung deleted the llvm-target-feature branch August 5, 2026 06:28

RalfJung mentioned this pull request Aug 5, 2026

Tracking issue for MCP 994: Add -Zllvm-target-feature target *modifier* to directly set LLVM-level target features, and deprecate doing that with -Ctarget-feature #157753

Open

8 tasks

Uh oh!

Uh oh!

Conversation

RalfJung commented Aug 3, 2026

Uh oh!

rustbot commented Aug 3, 2026

Uh oh!

This comment has been minimized.

folkertdev left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

RalfJung commented Aug 3, 2026

Uh oh!

folkertdev left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

RalfJung commented Aug 3, 2026

Uh oh!

antoyo commented Aug 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RalfJung commented Aug 3, 2026

Uh oh!

antoyo commented Aug 3, 2026

Uh oh!

RalfJung commented Aug 4, 2026

Uh oh!

rust-bors Bot commented Aug 4, 2026

Uh oh!

rustbot commented Aug 4, 2026

Uh oh!

rust-bors Bot commented Aug 4, 2026

Uh oh!

RalfJung commented Aug 4, 2026

Uh oh!

rust-bors Bot commented Aug 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

folkertdev left a comment •

edited by rustbot

Loading

folkertdev left a comment •

edited by rustbot

Loading

antoyo commented Aug 3, 2026 •

edited

Loading