Various steps in moving away from the big reflection enum to reflection functions - #159727
Open
oli-obk wants to merge 5 commits into
Open
Various steps in moving away from the big reflection enum to reflection functions#159727oli-obk wants to merge 5 commits into
oli-obk wants to merge 5 commits into
Conversation
Collaborator
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
fmease
reviewed
Jul 23, 2026
This was referenced Jul 23, 2026
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 27, 2026
… r=fmease Enforce that we don't generate code for comptime fns ... by ICEing if you try to compute a symbol for them. There are various other ways we can assert it, but they were all a bit icky or already unreachable. r? @fmease (since you asked about it in rust-lang#159727 (comment))
rust-timer
added a commit
that referenced
this pull request
Jul 27, 2026
Rollup merge of #159777 - oli-obk:really-comptime-this-time, r=fmease Enforce that we don't generate code for comptime fns ... by ICEing if you try to compute a symbol for them. There are various other ways we can assert it, but they were all a bit icky or already unreachable. r? @fmease (since you asked about it in #159727 (comment))
oli-obk
force-pushed
the
reflection_stuff
branch
from
July 28, 2026 06:50
f2afff8 to
0214ef6
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tracking issue: #146922
Some more of these and we can turn the big TyKind enum into one without any data, but I think these are enough steps for one PR, don't wanna turn it into a mega PR