Remove various superfluous lint attributes by mejrs · Pull Request #160085 · rust-lang/rust

        // Unlike all the other GC helpers where we check if an `AllocId` is found in the interpreter or
        // is live, here all the IDs in the map are for dead allocations so we don't
        // need to check for liveness.
-        #[allow(rustc::potential_query_instability)] // Only used from Miri, not queries.


Looks like this was missed in #120931

View changes since the review

mu001999 · 2026-07-28T15:19:17Z

Nice cleanup! r=me after CI green

mu001999 · 2026-07-28T15:28:00Z

By the way, I'm wondering how you found these to be superfluous

mejrs · 2026-07-28T15:38:41Z

By the way, I'm wondering how you found these to be superfluous

You start removing random allows and see whether something starts screaming at you 😜

Nadrieril · 2026-07-28T15:51:41Z

-// tidy-alphabetical-start
-#![allow(unused_crate_dependencies)]
-// tidy-alphabetical-end


Note that this is a librarified crate that may be compiled without the rustc feature. But I guess that flag is allowed by default in a normal compilation so maybe that's not relevant? I'm just wondering why it was there in the first place

View changes since the review

Looks like CI fails due to this.

It was added with the implementation of rust-lang/compiler-team#844, why I do not know. Sometimes with those cleanup prs it's preferable to add an allow here and there to avoid expanding the scope of the pr too much

and this is why:

warning: extern crate `tracing_subscriber` is unused in crate `rustc_pattern_analysis` | = help: remove the dependency or add `use tracing_subscriber as _;` to the crate root = note: requested on the command line with `-W unused-crate-dependencies` warning: extern crate `tracing_tree` is unused in crate `rustc_pattern_analysis` | = help: remove the dependency or add `use tracing_tree as _;` to the crate root

Hm, seems like this was added because of a false positive when compiling the compiler. So it used to trigger, and seems like it doesn't anymore, so it should be fine to remove. The only commit that vaguely could affect this since then is 67c6cd9 maybe? I'm ok with removing it at least.

Oh, y'all were so fast :D If it's these crates it's because they're used in tests. But they're explicitly used, idk why they'd trigger the warning.

They're only used in integration tests (not unit tests), that's probably why. I'll try to figure something out or back it out and add a comment.

mu001999 · 2026-07-29T03:05:43Z

@bors r+ rollup

rust-bors · 2026-07-29T03:05:46Z

📌 Commit 6db37c2 has been approved by mu001999

It is now in the queue for this repository.

Remove various superfluous lint attributes

Rollup of 6 pull requests Successful merges: - #158460 (Remove llvm_enzyme feature outside of bootstrap) - #159671 (Add semver check test command for checking API compatibility of stdlib) - #159717 (Add `-Zimplicit-sysroot-deps`) - #159994 (Show jobs where a given test was executed in `test-dashboard`) - #160085 (Remove various superfluous lint attributes) - #160123 (add additional license option for third-party dependencies)

JonathanBrouwer · 2026-07-29T10:20:07Z

💔 I suspect this PR failed tests as part of a rollup
@bors r-

After fixing the problem, consider running a try job for the failed job before re-approving.

Link to failure: #160135 (comment)

rust-bors · 2026-07-29T10:20:14Z

This pull request was unapproved.

This PR was contained in a rollup (#160135), which was unapproved.

View changes since this unapproval

rustbot · 2026-07-29T12:01:30Z

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

mejrs · 2026-07-29T12:02:53Z

@bors try jobs=dist-aarch64-linux

mejrs · 2026-07-29T13:03:15Z

@bors try jobs=dist-aarch64-linux

Remove various superfluous lint attributes try-job: dist-aarch64-linux

rust-bors · 2026-07-29T15:34:30Z

☀️ Try build successful (CI)
Build commit: f560859 (f560859bbd862a9afcdb458704fb47c4bdba4da0)
Base parent: ce69831 (ce6983167791bf9418726264f8e5cc7abf73d69b)

JonathanBrouwer · 2026-07-31T09:52:39Z

@bors r=JonathanBrouwer,mu001999 rollup

rust-bors · 2026-07-31T09:52:43Z

📌 Commit 9a17150 has been approved by JonathanBrouwer,mu001999

It is now in the queue for this repository.

…,mu001999 Remove various superfluous lint attributes

mejrs · 2026-07-31T10:02:47Z

@JonathanBrouwer did you actually review it? the changes to the PR are slightly more than just to fix the CI failure

JonathanBrouwer · 2026-07-31T10:04:05Z

Yes I read the entire diff of the PR :)

mejrs · 2026-07-31T10:06:09Z

Okay thanks, just making sure since I wasn't super obvious about it.

JonathanBrouwer · 2026-07-31T10:07:16Z

Yeah can't hurt, thanks for checking!

mu001999 · 2026-07-31T10:08:04Z

Should we do a perf run?

JonathanBrouwer · 2026-07-31T10:10:56Z

Changing from HashMap to IndexMap could theoretically affect the time it takes for rustc to compile itself as they might be slightly slower, but it should not be possible for it to affect rust-timer benchmarks since it runs fully in macros and the results are the same.

I think it's unlikely the change in compiletime is measurable tho. Is there a reliable way to measure this compiletime? Job duration is definitely too noisy

mu001999 · 2026-07-31T10:30:42Z

Oh it's in rustc_macros :)

…,mu001999 Remove various superfluous lint attributes

…uwer Rollup of 21 pull requests Successful merges: - #160100 (Add "system" option to `override-allocator` directive) - #159675 (rustc: Support `--jobs` options for limiting parallelism in various parts of the compiler) - #159999 (Fix invalidation of stdlib in bootstrap when using non-LLVM codegen backends) - #160233 (Bubble bad path error while parsing field to avoid unecessary second error) - #160272 (rustc_metadata: Move native library search code to `rustc_codegen_ssa`) - #154202 (rustfmt: Format `cfg_select!`) - #158835 (rustc_passes: lint unused `#[path]` attributes on inline modules) - #159520 (Suggest `Vec<T>` instead of `[T]`) - #160034 (Move "macro only" check for `#[allow_internal_unsafe/unstable]` to attribute parser) - #160066 (rustc_middle: lint attribute cleanups) - #160085 (Remove various superfluous lint attributes) - #160113 (Coalesce `rustc_on_unimplemented` attributes and lint malformed filters) - #160119 (fix query cycle in `coroutine_hidden_types` for the next solver) - #160147 (tests: Remove `-Zthreads` options from tests in `ui/parallel-rustc`) - #160157 (Remove outdated comments from `va_list.rs`) - #160159 (More accurately check for interior mutability in `invalid_reference_casting` lint) - #160208 (rustdoc: Fix crash when trying to list attributes on an opaque type) - #160244 (Rename splat to rustc_splat in error messages) - #160246 (dont fire `unused_mut` on `&pin mut self`) - #160247 (Configure backport nominations for rustfmt) - #160274 (renovate: update lock files weekly)

…uwer Rollup of 22 pull requests Successful merges: - #160100 (Add "system" option to `override-allocator` directive) - #160220 (Refactor: shrink region ext traits) - #159675 (rustc: Support `--jobs` options for limiting parallelism in various parts of the compiler) - #159999 (Fix invalidation of stdlib in bootstrap when using non-LLVM codegen backends) - #160233 (Bubble bad path error while parsing field to avoid unecessary second error) - #160272 (rustc_metadata: Move native library search code to `rustc_codegen_ssa`) - #154202 (rustfmt: Format `cfg_select!`) - #159520 (Suggest `Vec<T>` instead of `[T]`) - #159710 (Add rustdoc/cargo PGO profiles to reproducible artifacts) - #160034 (Move "macro only" check for `#[allow_internal_unsafe/unstable]` to attribute parser) - #160066 (rustc_middle: lint attribute cleanups) - #160085 (Remove various superfluous lint attributes) - #160113 (Coalesce `rustc_on_unimplemented` attributes and lint malformed filters) - #160119 (fix query cycle in `coroutine_hidden_types` for the next solver) - #160147 (tests: Remove `-Zthreads` options from tests in `ui/parallel-rustc`) - #160157 (Remove outdated comments from `va_list.rs`) - #160159 (More accurately check for interior mutability in `invalid_reference_casting` lint) - #160208 (rustdoc: Fix crash when trying to list attributes on an opaque type) - #160244 (Rename splat to rustc_splat in error messages) - #160246 (dont fire `unused_mut` on `&pin mut self`) - #160247 (Configure backport nominations for rustfmt) - #160274 (renovate: update lock files weekly)

Rollup merge of #160085 - mejrs:bye_lints, r=JonathanBrouwer,mu001999 Remove various superfluous lint attributes

rustbot assigned mu001999 Jul 28, 2026

mejrs commented Jul 28, 2026

View reviewed changes

Nadrieril reviewed Jul 28, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

mejrs force-pushed the bye_lints branch from 0d89790 to 6db37c2 Compare July 28, 2026 16:39

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 29, 2026

jhpratt added a commit to jhpratt/rust that referenced this pull request Jul 29, 2026

Rollup merge of rust-lang#160085 - mejrs:bye_lints, r=mu001999

a1dbad8

Remove various superfluous lint attributes

jhpratt mentioned this pull request Jul 29, 2026

Rollup of 5 pull requests #160128

Closed

jhpratt added a commit to jhpratt/rust that referenced this pull request Jul 29, 2026

Rollup merge of rust-lang#160085 - mejrs:bye_lints, r=mu001999

93b881f

Remove various superfluous lint attributes

jhpratt mentioned this pull request Jul 29, 2026

Rollup of 6 pull requests #160135

Closed

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 29, 2026

Remove various superfluous lint attributes

c955c63

mejrs force-pushed the bye_lints branch from 6db37c2 to f30c288 Compare July 29, 2026 12:01

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Jul 29, 2026

Auto merge of #160085 - mejrs:bye_lints, r=<try>

f560859

Remove various superfluous lint attributes try-job: dist-aarch64-linux

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 31, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 31, 2026

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 31, 2026

Rollup merge of rust-lang#160085 - mejrs:bye_lints, r=JonathanBrouwer…

2228682

…,mu001999 Remove various superfluous lint attributes

JonathanBrouwer mentioned this pull request Jul 31, 2026

Rollup of 11 pull requests #160273

Closed

JonathanBrouwer self-assigned this Jul 31, 2026

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 31, 2026

Rollup merge of rust-lang#160085 - mejrs:bye_lints, r=JonathanBrouwer…

f06483f

…,mu001999 Remove various superfluous lint attributes

JonathanBrouwer mentioned this pull request Jul 31, 2026

Rollup of 17 pull requests #160278

Closed

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 31, 2026

Rollup merge of rust-lang#160085 - mejrs:bye_lints, r=JonathanBrouwer…

21f6ad5

…,mu001999 Remove various superfluous lint attributes

JonathanBrouwer mentioned this pull request Jul 31, 2026

Rollup of 21 pull requests #160283

Closed

JonathanBrouwer mentioned this pull request Jul 31, 2026

Rollup of 22 pull requests #160284

Merged

rust-bors Bot merged commit a621f18 into rust-lang:main Jul 31, 2026
14 checks passed

rustbot added this to the 1.99.0 milestone Jul 31, 2026

rust-timer added a commit that referenced this pull request Jul 31, 2026

Unrolled build for #160085

c1e82f3

Rollup merge of #160085 - mejrs:bye_lints, r=JonathanBrouwer,mu001999 Remove various superfluous lint attributes

Uh oh!

Uh oh!

Conversation

mejrs commented Jul 28, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 28, 2026

Uh oh!

rustbot commented Jul 28, 2026

Uh oh!

mejrs Jul 28, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mu001999 commented Jul 28, 2026

Uh oh!

mu001999 commented Jul 28, 2026

Uh oh!

mejrs commented Jul 28, 2026

Uh oh!

Nadrieril Jul 28, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mu001999 Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mejrs Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Nadrieril Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Nadrieril Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

mejrs Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

mu001999 commented Jul 29, 2026

Uh oh!

rust-bors Bot commented Jul 29, 2026

Uh oh!

JonathanBrouwer commented Jul 29, 2026

Uh oh!

rust-bors Bot commented Jul 29, 2026

Uh oh!

rustbot commented Jul 29, 2026

Uh oh!

mejrs commented Jul 29, 2026

Uh oh!

mejrs commented Jul 29, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jul 29, 2026

Uh oh!

JonathanBrouwer commented Jul 31, 2026

Uh oh!

rust-bors Bot commented Jul 31, 2026

Uh oh!

mejrs commented Jul 31, 2026

Uh oh!

JonathanBrouwer commented Jul 31, 2026

Uh oh!

mejrs commented Jul 31, 2026

Uh oh!

JonathanBrouwer commented Jul 31, 2026

Uh oh!

mu001999 commented Jul 31, 2026

Uh oh!

JonathanBrouwer commented Jul 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mu001999 commented Jul 31, 2026

Uh oh!

Uh oh!

mejrs commented Jul 28, 2026 •

edited by rustbot

Loading

mejrs Jul 28, 2026 •

edited by rustbot

Loading

Nadrieril Jul 28, 2026 •

edited by rustbot

Loading

mu001999 Jul 28, 2026 •

edited

Loading

mejrs Jul 28, 2026 •

edited

Loading

Nadrieril Jul 28, 2026 •

edited

Loading

JonathanBrouwer commented Jul 31, 2026 •

edited

Loading