Show jobs where a given test was executed in test-dashboard - #159994
Conversation
There was a problem hiding this comment.
Remark: tried to test the invocation locally, but I got
Downloading metrics of job aarch64-gnu
Downloading metrics of job aarch64-gnu-debug
Downloading metrics of job arm-android
Downloading metrics of job armhf-gnu
Downloading metrics of job dist-aarch64-linux
Downloading metrics of job dist-android
Downloading metrics of job dist-arm-linux-gnueabi
Downloading metrics of job dist-arm-linux-musl
Downloading metrics of job dist-armhf-linux
Downloading metrics of job dist-armv7-linux
Downloading metrics of job dist-i586-gnu-i586-i686-musl
Downloading metrics of job dist-i686-linux
Downloading metrics of job dist-loongarch64-linux
Downloading metrics of job dist-loongarch64-musl
Downloading metrics of job dist-ohos-aarch64
Downloading metrics of job dist-ohos-armv7
Downloading metrics of job dist-ohos-x86_64
Downloading metrics of job dist-powerpc-linux
Downloading metrics of job dist-powerpc64-linux-gnu
Downloading metrics of job dist-powerpc64-linux-musl
Downloading metrics of job dist-powerpc64le-linux-gnu
Downloading metrics of job dist-powerpc64le-linux-musl
Downloading metrics of job dist-riscv64-linux-gnu
Downloading metrics of job dist-riscv64-linux-musl
Downloading metrics of job dist-s390x-linux
Downloading metrics of job dist-various-1
Downloading metrics of job dist-various-2
Downloading metrics of job dist-x86_64-freebsd
Downloading metrics of job dist-aarch64-freebsd
Downloading metrics of job dist-x86_64-illumos
Downloading metrics of job dist-x86_64-linux
Downloading metrics of job dist-x86_64-linux-alt
Downloading metrics of job dist-x86_64-musl
Downloading metrics of job dist-x86_64-netbsd
Downloading metrics of job dist-x86_64-solaris
Downloading metrics of job dist-sparcv9-solaris
Downloading metrics of job i686-gnu-1
Downloading metrics of job i686-gnu-2
Downloading metrics of job i686-gnu-nopt-1
Downloading metrics of job i686-gnu-nopt-2
Downloading metrics of job pr-check-1
Downloading metrics of job pr-check-2
Downloading metrics of job tidy
Downloading metrics of job test-various
Downloading metrics of job x86_64-rust-for-linux
Downloading metrics of job x86_64-gnu
Downloading metrics of job x86_64-gnu-parallel-frontend
Error: http status: 404
I think sometimes metrics might be unavailable for a given job for one reason or another, maybe need to just... ignore or add a warning that one of the job is missing? Unsure.
Anyway, I picked a recent rollup and no metrics was missing there, so that's fine.
There was a problem hiding this comment.
Right, the job got renamed, but we take the list of job names from main, because it's hard to guess it just from the commit SHA (we'd have to run citool or parse jobs.yml from that commit to find out, or somehow scan S3).
I was thinking that we should ignore errors, but errors here are actually useful on CI (for detecting failed optional jobs 😂 ). Maybe fail on CI, but ignore locally, is the sweet spot.
There was a problem hiding this comment.
Probably we should store in S3 a file with one line per CI job that is executed, to make this easier, also for other tooling.
There was a problem hiding this comment.
Yeah... I'm not super sure what to do about errors like this. Ignoring locally but error in CI feels okay, because locally it's Well Too Bad No Metrics indeed.
There was a problem hiding this comment.
Remark: played around with this locally, job sets are a big improvement over "no idea which jobs run this test", but I feel like the UX is a bit tricky. Right now we end up with some J2xx 200 job sets, which feels... quite a lot?
Ideally we'd be able to filter (with a checkbox or sth) by job, or maybe just have a given test expand out which jobs run the test. However, that probably involves some JS which, you know, having a dumb HTML page is actually quite nice...
There was a problem hiding this comment.
I didn't expand the jobs because the HTML file is already huge, and even including a <title> or manifesting the jobs would make ot much larger, I think.
But yeah, some JS would help.
There was a problem hiding this comment.
Makes sense yeah, that did occurr to me.
…ouxu Show jobs where a given test was executed in `test-dashboard` This lets us see the specific set of jobs where a given test was executed on CI. This should be quite useful e.g. for debugging where we run debuginfo tests. To test: ```bash $ cargo run --release --manifest-path src/ci/citool/Cargo.toml -- test-dashboard 008fa22 --output-dir test-dashboard ``` r? @jieyouxu
…ouxu Show jobs where a given test was executed in `test-dashboard` This lets us see the specific set of jobs where a given test was executed on CI. This should be quite useful e.g. for debugging where we run debuginfo tests. To test: ```bash $ cargo run --release --manifest-path src/ci/citool/Cargo.toml -- test-dashboard 008fa22 --output-dir test-dashboard ``` r? @jieyouxu
Rollup of 6 pull requests Successful merges: - #158460 (Remove llvm_enzyme feature outside of bootstrap) - #159671 (Add semver check test command for checking API compatibility of stdlib) - #159717 (Add `-Zimplicit-sysroot-deps`) - #159994 (Show jobs where a given test was executed in `test-dashboard`) - #160085 (Remove various superfluous lint attributes) - #160123 (add additional license option for third-party dependencies)
…ouxu Show jobs where a given test was executed in `test-dashboard` This lets us see the specific set of jobs where a given test was executed on CI. This should be quite useful e.g. for debugging where we run debuginfo tests. To test: ```bash $ cargo run --release --manifest-path src/ci/citool/Cargo.toml -- test-dashboard 008fa22 --output-dir test-dashboard ``` r? @jieyouxu
…uwer Rollup of 11 pull requests Successful merges: - #158460 (Remove llvm_enzyme feature outside of bootstrap) - #159509 (Generate `valid_range`s for enums sign-agnostically) - #159632 (CFI: Add support for the adt_const_params feature) - #159671 (Add semver check test command for checking API compatibility of stdlib) - #157058 (Rustdoc label badge for notable traits) - #159717 (Add `-Zimplicit-sysroot-deps`) - #159850 (Add regression test for closure in array-length const generic) - #159994 (Show jobs where a given test was executed in `test-dashboard`) - #160110 (convert rustc_hir::Target inherent methods to From impls) - #160123 (add additional license option for third-party dependencies) - #160131 (bootstrap: remove temporary bors email lookup)
…uwer Rollup of 11 pull requests Successful merges: - #158460 (Remove llvm_enzyme feature outside of bootstrap) - #159509 (Generate `valid_range`s for enums sign-agnostically) - #159632 (CFI: Add support for the adt_const_params feature) - #159671 (Add semver check test command for checking API compatibility of stdlib) - #157058 (Rustdoc label badge for notable traits) - #159717 (Add `-Zimplicit-sysroot-deps`) - #159850 (Add regression test for closure in array-length const generic) - #159994 (Show jobs where a given test was executed in `test-dashboard`) - #160110 (convert rustc_hir::Target inherent methods to From impls) - #160123 (add additional license option for third-party dependencies) - #160131 (bootstrap: remove temporary bors email lookup)
Rollup merge of #159994 - Kobzol:test-dashboard-jobs, r=jieyouxu Show jobs where a given test was executed in `test-dashboard` This lets us see the specific set of jobs where a given test was executed on CI. This should be quite useful e.g. for debugging where we run debuginfo tests. To test: ```bash $ cargo run --release --manifest-path src/ci/citool/Cargo.toml -- test-dashboard 008fa22 --output-dir test-dashboard ``` r? @jieyouxu
This lets us see the specific set of jobs where a given test was executed on CI. This should be quite useful e.g. for debugging where we run debuginfo tests.
To test:
r? @jieyouxu