Move "macro only" check for `#[allow_internal_unsafe/unstable]` to attribute parser by sethryanrollins · Pull Request #160034 · rust-lang/rust

sethryanrollins · 2026-07-28T01:21:07Z

Part of #131229 which is the parent issue of #153101

@JonathanBrouwer

rustbot · 2026-07-28T01:21:11Z

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

rustbot · 2026-07-28T01:21:13Z

Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @mati865 (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

@rustbot author: the review is finished, PR author should check the comments and take action accordingly
@rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 74 candidates
Random selection from 20 candidates

mati865 · 2026-07-30T12:27:23Z

@rustbot reroll

JonathanBrouwer · 2026-07-30T12:30:48Z

r? me
I'm happy to review this after the merge commit is fixed

sethryanrollins · 2026-07-30T12:32:45Z

I can fix the conflict within the hour once I get into work

rustbot · 2026-07-30T13:37:33Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

JonathanBrouwer · 2026-07-31T10:01:26Z

+/// Applying them to a function is only allowed if that function is a procedural macro, i.e. it
+/// also carries `#[proc_macro]`, `#[proc_macro_attribute]`, or `#[proc_macro_derive]`.
+pub(crate) fn check_macro_only(cx: &FinalizeCheckContext<'_, '_>, attr_span: Span) {
+    if cx.target == Target::Fn


Is this cx.target == Target::Fn check necessary? Does the finalize_check run if target checking fails?

View changes since the review

Oh right it's necessary because these attributes are also valid on Target::MacroDef, this makes sense

JonathanBrouwer

@bors r+ rollup
Thanks! (also made your title a bit clearer :3)

View changes since this review

rust-bors · 2026-07-31T10:02:31Z

📌 Commit ccc55c3 has been approved by JonathanBrouwer

It is now in the queue for this repository.

sethryanrollins · 2026-07-31T10:06:33Z

@JonathanBrouwer ahah many thanks!

@JonathanBrouwer

…/check_macro_only_attr, r=JonathanBrouwer Move "macro only" check for `#[allow_internal_unsafe/unstable]` to attribute parser Part of rust-lang#131229 which is the parent issue of rust-lang#153101 @JonathanBrouwer

@JonathanBrouwer

…/check_macro_only_attr, r=JonathanBrouwer Move "macro only" check for `#[allow_internal_unsafe/unstable]` to attribute parser Part of rust-lang#131229 which is the parent issue of rust-lang#153101 @JonathanBrouwer

…uwer Rollup of 21 pull requests Successful merges: - #160100 (Add "system" option to `override-allocator` directive) - #159675 (rustc: Support `--jobs` options for limiting parallelism in various parts of the compiler) - #159999 (Fix invalidation of stdlib in bootstrap when using non-LLVM codegen backends) - #160233 (Bubble bad path error while parsing field to avoid unecessary second error) - #160272 (rustc_metadata: Move native library search code to `rustc_codegen_ssa`) - #154202 (rustfmt: Format `cfg_select!`) - #158835 (rustc_passes: lint unused `#[path]` attributes on inline modules) - #159520 (Suggest `Vec<T>` instead of `[T]`) - #160034 (Move "macro only" check for `#[allow_internal_unsafe/unstable]` to attribute parser) - #160066 (rustc_middle: lint attribute cleanups) - #160085 (Remove various superfluous lint attributes) - #160113 (Coalesce `rustc_on_unimplemented` attributes and lint malformed filters) - #160119 (fix query cycle in `coroutine_hidden_types` for the next solver) - #160147 (tests: Remove `-Zthreads` options from tests in `ui/parallel-rustc`) - #160157 (Remove outdated comments from `va_list.rs`) - #160159 (More accurately check for interior mutability in `invalid_reference_casting` lint) - #160208 (rustdoc: Fix crash when trying to list attributes on an opaque type) - #160244 (Rename splat to rustc_splat in error messages) - #160246 (dont fire `unused_mut` on `&pin mut self`) - #160247 (Configure backport nominations for rustfmt) - #160274 (renovate: update lock files weekly)

…uwer Rollup of 22 pull requests Successful merges: - #160100 (Add "system" option to `override-allocator` directive) - #160220 (Refactor: shrink region ext traits) - #159675 (rustc: Support `--jobs` options for limiting parallelism in various parts of the compiler) - #159999 (Fix invalidation of stdlib in bootstrap when using non-LLVM codegen backends) - #160233 (Bubble bad path error while parsing field to avoid unecessary second error) - #160272 (rustc_metadata: Move native library search code to `rustc_codegen_ssa`) - #154202 (rustfmt: Format `cfg_select!`) - #159520 (Suggest `Vec<T>` instead of `[T]`) - #159710 (Add rustdoc/cargo PGO profiles to reproducible artifacts) - #160034 (Move "macro only" check for `#[allow_internal_unsafe/unstable]` to attribute parser) - #160066 (rustc_middle: lint attribute cleanups) - #160085 (Remove various superfluous lint attributes) - #160113 (Coalesce `rustc_on_unimplemented` attributes and lint malformed filters) - #160119 (fix query cycle in `coroutine_hidden_types` for the next solver) - #160147 (tests: Remove `-Zthreads` options from tests in `ui/parallel-rustc`) - #160157 (Remove outdated comments from `va_list.rs`) - #160159 (More accurately check for interior mutability in `invalid_reference_casting` lint) - #160208 (rustdoc: Fix crash when trying to list attributes on an opaque type) - #160244 (Rename splat to rustc_splat in error messages) - #160246 (dont fire `unused_mut` on `&pin mut self`) - #160247 (Configure backport nominations for rustfmt) - #160274 (renovate: update lock files weekly)

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 28, 2026

rustbot assigned mati865 Jul 28, 2026

This comment has been minimized.

Sign in to view

rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 28, 2026

sethryanrollins force-pushed the sethr/issue-153101/check_macro_only_attr branch from 1d88cdc to b8cbe9a Compare July 28, 2026 13:58

This comment has been minimized.

Sign in to view

rustbot removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. has-merge-commits PR has merge commits, merge with caution. labels Jul 28, 2026

This comment has been minimized.

Sign in to view

rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 29, 2026

rustbot assigned TaKO8Ki and unassigned mati865 Jul 30, 2026

rustbot assigned JonathanBrouwer and unassigned TaKO8Ki Jul 30, 2026

refactor(attrs): move check_macro_only_attr into the attribute parsers

ccc55c3

sethryanrollins force-pushed the sethr/issue-153101/check_macro_only_attr branch from c7bce2c to ccc55c3 Compare July 30, 2026 13:37

rustbot removed has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 30, 2026

JonathanBrouwer changed the title ~~Sethr/issue 153101/check macro only attr~~ Move "macro only" check for #[allow_internal_unsafe/unstable] to attribute parser Jul 31, 2026

JonathanBrouwer reviewed Jul 31, 2026

View reviewed changes

JonathanBrouwer approved these changes Jul 31, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 31, 2026

JonathanBrouwer mentioned this pull request Jul 31, 2026

Rollup of 17 pull requests #160278

Closed

JonathanBrouwer mentioned this pull request Jul 31, 2026

Rollup of 21 pull requests #160283

Closed

JonathanBrouwer mentioned this pull request Jul 31, 2026

Rollup of 22 pull requests #160284

Merged

rust-bors Bot merged commit 6b1aa7a into rust-lang:main Jul 31, 2026
13 checks passed

rustbot added this to the 1.99.0 milestone Jul 31, 2026

Uh oh!

Uh oh!

Conversation

sethryanrollins commented Jul 28, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 28, 2026

Uh oh!

rustbot commented Jul 28, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

mati865 commented Jul 30, 2026

Uh oh!

JonathanBrouwer commented Jul 30, 2026

Uh oh!

sethryanrollins commented Jul 30, 2026

Uh oh!

rustbot commented Jul 30, 2026

Uh oh!

JonathanBrouwer Jul 31, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JonathanBrouwer Jul 31, 2026

Choose a reason for hiding this comment

Uh oh!

JonathanBrouwer left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented Jul 31, 2026

Uh oh!

sethryanrollins commented Jul 31, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sethryanrollins commented Jul 28, 2026 •

edited by rustbot

Loading

JonathanBrouwer Jul 31, 2026 •

edited by rustbot

Loading

JonathanBrouwer left a comment •

edited

Loading