Extend size of :targeted elements#492
Closed
TooManyBees wants to merge 1 commit into
Closed
Conversation
When the browser follows a link with a `#fragment`, it scrolls up or down to put the element with the matching `id` attribute at the top of the window. In rustdoc output, that's usually section headers. docs.rs's floating top navbar hides that element. This PR extends the height of the element the browser is scrolling to, in a way that doesn't affect its visual appearance, so that it lands below the navbar and is visible to the user.
Member
|
It actually has already been fixed in #465. But for some reasons, the |
Member
|
@TooManyBees This should have been fixed in #496, can you take a look at the deployed site (e.g. https://docs.rs/parze/0.5.1/parze/also/trait.Also.html#tymethod.also) and make sure it looks good? If so I'll close this. |
Author
|
i guess it's already fixed then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the browser follows a link with a
#fragment, it scrolls up ordown to put the element with the matching
idattribute at the topof the window. In rustdoc output, that's usually section headers.
docs.rs's floating top navbar hides that element. This PR extends
the height of the element the browser is scrolling to, in a way that
doesn't affect its visual appearance, so that it lands below the
navbar and is visible to the user.