Fix top banner hiding text#465
Conversation
|
I didn't even realize this was a problem with docs.rs, I thought firefox was being wacky. Thanks for fixing this! |
jyn514
left a comment
There was a problem hiding this comment.
Looks great besides this one nit!
There was a problem hiding this comment.
It looks like taking out this 'padding' style makes the search bar overlap with the style button, at least in my browser.
There was a problem hiding this comment.
Oh funny. Can you open an issue about this (and maybe even a PR?). I don't want to mix more things in this PR.
There was a problem hiding this comment.
I'm not sure I understand, do you mean in the main rust repo? If you just add the padding back in (like it was before) it works fine.
There was a problem hiding this comment.
Oh crap! Completely missed the fact that I removed it. Good catch! Sorry for not understanding at first.
33527fe to
60ded3b
Compare
|
@jyn514 I have put back what I mistakenly removed. |
|
Great, thanks so much! |
I don't know what happened with the CSS formatting so I fixed it... But the important commit is the second one: it prevents text to go under the top banner. For example: https://docs.rs/halt/0.3.0/halt/struct.Invalid.html#implementations, the title won't "disappear" under the banner.
cc @pietroalbini