Conversation
The file was added to the css folder by mistake, it's supposed to be generated from templates/style.scss
They're not actually being used for the main website, and the crates built with that nightly will load their essential files anyway.
This commit removes the vendored CSS of Rustdoc 1.10.0-nightly, changing the site to always use the lastest Rustdoc's one. To do that, the Docker entrypoint is changed to add the essential files the first time the container is started, and the frontend now queries the database to see the version of the files to include. The version is cached by the first page loaded by users, and doesn't change unless the application is restarted. This is fine, since the application is restarted often enough and using a CSS older by a few nightlies is not so big of a deal. The cache also prevents response time regressions.
Member
Author
|
cc @GuillaumeGomez as well |
GuillaumeGomez
approved these changes
Nov 27, 2019
Member
|
Can you also apply 60ded3b to |
jyn514
reviewed
Nov 27, 2019
Member
jyn514
left a comment
There was a problem hiding this comment.
Looks good except for the one comment about the entrypoint, I think it can be avoided by rearranging the logic a little.
Member
Author
Ported the configuration. |
Member
|
Hmm, I see your changes in the CSS but the toolbar still overlaps with the item ... but that's separate from your changes here, we can fix it later.
|
Member
|
ah wait I'm on the wrong git branch lol one sec |
Member
|
Ok yeah this looks great! |
jyn514
added a commit
to jyn514/docs.rs
that referenced
this pull request
Nov 27, 2019
I'm not sure why it was disabled in the first place, but it started affecting users after rust-lang#496 was merged.
Merged
jyn514
added a commit
that referenced
this pull request
Nov 27, 2019
I'm not sure why it was disabled in the first place, but it started affecting users after #496 was merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes some of the CSS mess contained in this repository:
css/style.css, as it was just an out of date copy of the generatedtemplates/style.scss. The file was actually never served to users, as the SCSS generated on the fly takes precedence.1.40.0-nightlyvendored CSS files, as they're not used by anything.1.10.0-nightlyvendored CSS files, and changed the application to use the latest nightly's essential files instead of the 1.10 ones. This required a change in the Docker entrypoint to load the essential files the first time the container is started, and a few tweaks to ourstyle.scssto workaround the changes in Rustdoc's CSS since 1.10.css/tostatic/in the repository, as it now only containsfavicon.ico.r? @jyn514