Decompose libkineto_defs.bzl source lists into atoms (#1493) - #1493
Closed
scotts wants to merge 1 commit into
Closed
Decompose libkineto_defs.bzl source lists into atoms (#1493)#1493scotts wants to merge 1 commit into
scotts wants to merge 1 commit into
Conversation
|
@scotts has exported this pull request. If you are a Meta employee, you can view the originating Diff in D113455552. |
scotts
force-pushed
the
export-D113455552
branch
from
July 24, 2026 16:11
23ad8fd to
82ec7c8
Compare
Summary: In anticipation of Kineto going GitHub-first, we're making the build more PyTorch-like. Something that PyTorch does to reduce churn when GitHub PRs are imported is to define internal build files using source definitions from the same bzl files that CMake uses. Here, we refactor the bzl file so that there are "atoms" that BUCK can use directly. Reviewed By: ryanzhang22 Differential Revision: D113455552
scotts
force-pushed
the
export-D113455552
branch
from
July 24, 2026 18:05
82ec7c8 to
1900545
Compare
|
This pull request has been merged in 328fa51. |
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Jul 30, 2026
Includes the following commits: - Clean up dtypes for metadata fields (pytorch/kineto#1499) 6f446fe - [xpupti] Fix Windows build support for xpupti tests and multi-config generators. (pytorch/kineto#1394) 9e826ca - Test ConfigLoader on-demand daemon poll ingress (pytorch/kineto#1504) 7674d28 - Remove comment about documentation (pytorch/kineto#1503) eeb3db9 - Remove HTA from README (pytorch/kineto#1502) 46b1c63 - Catch config-update exceptions so the poll thread can't crash the process (pytorch/kineto#1498) be334e1 - Drop EventProfiler config kind from ConfigLoader (pytorch/kineto#1496) e7c97a6 - Remove event-only config surface from Config (pytorch/kineto#1495) a3a0566 - Remove dead event profiler: runtime, CUPTI backends, build wiring (pytorch/kineto#1494) 36c2e05 - Decompose libkineto_defs.bzl source lists into atoms (pytorch/kineto#1493) 328fa51 - Add XPU synchronization events to XPUPTI profiler (pytorch/kineto#1395) 8285e5b - Re-enable CI linting and lint all C++ (pytorch/kineto#1489) 2c41c01 - Test ConfigLoader handler fan-out (pytorch/kineto#1487) cccc5d1 - Update C++ lint tooling (pytorch/kineto#1488) 57e59e6 Pull Request resolved: #191526 Approved by: https://github.com/scotts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
In anticipation of Kineto going GitHub-first, we're making the build more PyTorch-like. Something that PyTorch does to reduce churn when GitHub PRs are imported is to define internal build files using source definitions from the same bzl files that CMake uses. Here, we refactor the bzl file so that there are "atoms" that BUCK can use directly.
Reviewed By: ryanzhang22
Differential Revision: D113455552