Re-enable CI linting and lint all C++ - #1489
Closed
scotts wants to merge 1 commit into
Closed
Conversation
The lint tooling landed (disabled) in pytorch#1488. Enable the CI lint job (rename lint.yml.disabled to lint.yml) together with the mechanical reformat that makes the existing tree compliant, so the job goes live only once the code passes. The reformat is the output of lintrunner -a --all-files with the pinned clang-format: 75 C++ files under libkineto/, formatting only, no behavior change. Test Plan: uv tool run lintrunner --all-files # exits 0 Authored with assistance from an AI agent (Claude Code).
scotts
force-pushed
the
reenable-github-lint-enable
branch
from
July 22, 2026 16:41
6b9e258 to
88c33a5
Compare
|
@scotts has imported this pull request. If you are a Meta employee, you can view this in D113276882. |
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Jul 30, 2026
Includes the following commits: - Clean up dtypes for metadata fields (pytorch/kineto#1499) 6f446fe - [xpupti] Fix Windows build support for xpupti tests and multi-config generators. (pytorch/kineto#1394) 9e826ca - Test ConfigLoader on-demand daemon poll ingress (pytorch/kineto#1504) 7674d28 - Remove comment about documentation (pytorch/kineto#1503) eeb3db9 - Remove HTA from README (pytorch/kineto#1502) 46b1c63 - Catch config-update exceptions so the poll thread can't crash the process (pytorch/kineto#1498) be334e1 - Drop EventProfiler config kind from ConfigLoader (pytorch/kineto#1496) e7c97a6 - Remove event-only config surface from Config (pytorch/kineto#1495) a3a0566 - Remove dead event profiler: runtime, CUPTI backends, build wiring (pytorch/kineto#1494) 36c2e05 - Decompose libkineto_defs.bzl source lists into atoms (pytorch/kineto#1493) 328fa51 - Add XPU synchronization events to XPUPTI profiler (pytorch/kineto#1395) 8285e5b - Re-enable CI linting and lint all C++ (pytorch/kineto#1489) 2c41c01 - Test ConfigLoader handler fan-out (pytorch/kineto#1487) cccc5d1 - Update C++ lint tooling (pytorch/kineto#1488) 57e59e6 Pull Request resolved: #191526 Approved by: https://github.com/scotts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are many changed files, but it's all linting. We: