[xpupti] Add XPU synchronization events to XPUPTI profiler - #1395
Closed
tsocha wants to merge 14 commits into
Closed
[xpupti] Add XPU synchronization events to XPUPTI profiler#1395tsocha wants to merge 14 commits into
tsocha wants to merge 14 commits into
Conversation
Introduce a new ActivityType::XPU_SYNC that surfaces device synchronization records from PTI_VIEW_DEVICE_SYNCHRONIZATION in the XPUPTI plugin. - Register XPU_SYNC in ActivityType (value 27) and update ENUM_COUNT / name table. - Enable/disable PTI_VIEW_DEVICE_SYNCHRONIZATION alongside the other XPUPTI activity kinds. - Add handleSynchronizationActivity, including a synchronization-type -> string map, GPU vs. host barrier accounting, and metadata (context/queue/event handles, wait-event count, return code). - Generalize getApiName into a template so it works for both API and synchronization records; move it to the header. - Route PTI_VIEW_DEVICE_SYNCHRONIZATION in handlePtiActivity. - Cover the new handler with unit tests in XpuptiActivityHandlersTest.cpp.
Contributor
Author
|
@gujinghui please review it. |
gujinghui
reviewed
May 12, 2026
gujinghui
approved these changes
Jun 2, 2026
|
@divyanshk @scotts This PR is ready for your review. Thanks. |
|
@scotts @ryanzhang22 |
|
@ryanzhang22 has imported this pull request. If you are a Meta employee, you can view this in D112382372. |
Contributor
Author
|
@ryanzhang22 The CI passed, could you merge it? |
Contributor
|
this is landing internally and will get synced here soon. it's just being slow to test. |
Contributor
Author
I see, thank you for the update. |
|
@ryanzhang22 merged this pull request in 8285e5b. |
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Jul 30, 2026
Includes the following commits: - Clean up dtypes for metadata fields (pytorch/kineto#1499) 6f446fe - [xpupti] Fix Windows build support for xpupti tests and multi-config generators. (pytorch/kineto#1394) 9e826ca - Test ConfigLoader on-demand daemon poll ingress (pytorch/kineto#1504) 7674d28 - Remove comment about documentation (pytorch/kineto#1503) eeb3db9 - Remove HTA from README (pytorch/kineto#1502) 46b1c63 - Catch config-update exceptions so the poll thread can't crash the process (pytorch/kineto#1498) be334e1 - Drop EventProfiler config kind from ConfigLoader (pytorch/kineto#1496) e7c97a6 - Remove event-only config surface from Config (pytorch/kineto#1495) a3a0566 - Remove dead event profiler: runtime, CUPTI backends, build wiring (pytorch/kineto#1494) 36c2e05 - Decompose libkineto_defs.bzl source lists into atoms (pytorch/kineto#1493) 328fa51 - Add XPU synchronization events to XPUPTI profiler (pytorch/kineto#1395) 8285e5b - Re-enable CI linting and lint all C++ (pytorch/kineto#1489) 2c41c01 - Test ConfigLoader handler fan-out (pytorch/kineto#1487) cccc5d1 - Update C++ lint tooling (pytorch/kineto#1488) 57e59e6 Pull Request resolved: #191526 Approved by: https://github.com/scotts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a part of #1335 2/3
Introduce a new ActivityType::XPU_SYNC that surfaces device synchronization records from PTI_VIEW_DEVICE_SYNCHRONIZATION in the XPUPTI plugin.