[ET-VK] Minor improvement to q_linear op shader.#7728
Merged
facebook-github-bot merged 8 commits intogh/trivedivivek/45/basefrom Jan 24, 2025
Merged
[ET-VK] Minor improvement to q_linear op shader.#7728facebook-github-bot merged 8 commits intogh/trivedivivek/45/basefrom
facebook-github-bot merged 8 commits intogh/trivedivivek/45/basefrom
Conversation
This diff contains a minor improvement to the q_linear op shader in the Vulkan backend for Executorch. The code changes in the q_8w_linear.glsl file include a change in position parameter from a 3-element u16vec3 to a 2-element u16vec2. Differential Revision: [D68113154](https://our.internmc.facebook.com/intern/diff/D68113154/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7728
Note: Links to docs will display an error until the docs builds have been completed. ⏳ 3 Pending, 1 Unrelated FailureAs of commit c72ff0f with merge base f73b8cf ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68113154 |
trviv
added a commit
that referenced
this pull request
Jan 17, 2025
This diff contains a minor improvement to the q_linear op shader in the Vulkan backend for Executorch. The code changes in the q_8w_linear.glsl file include a change in position parameter from a 3-element u16vec3 to a 2-element u16vec2. Differential Revision: [D68113154](https://our.internmc.facebook.com/intern/diff/D68113154/) ghstack-source-id: 261906021 Pull Request resolved: #7728
nathanaelsee
approved these changes
Jan 17, 2025
This diff contains a minor improvement to the q_linear op shader in the Vulkan backend for Executorch. The code changes in the q_8w_linear.glsl file include a change in position parameter from a 3-element u16vec3 to a 2-element u16vec2. Differential Revision: [D68113154](https://our.internmc.facebook.com/intern/diff/D68113154/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68113154 |
trviv
added a commit
that referenced
this pull request
Jan 21, 2025
Pull Request resolved: #7728 This diff contains a minor improvement to the q_linear op shader in the Vulkan backend for Executorch. The code changes in the q_8w_linear.glsl file include a change in position parameter from a 3-element u16vec3 to a 2-element u16vec2. Differential Revision: [D68113154](https://our.internmc.facebook.com/intern/diff/D68113154/) ghstack-source-id: 262384610
This was referenced Jan 21, 2025
This diff contains a minor improvement to the q_linear op shader in the Vulkan backend for Executorch. The code changes in the q_8w_linear.glsl file include a change in position parameter from a 3-element u16vec3 to a 2-element u16vec2. Differential Revision: [D68113154](https://our.internmc.facebook.com/intern/diff/D68113154/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68113154 |
This diff contains a minor improvement to the q_linear op shader in the Vulkan backend for Executorch. The code changes in the q_8w_linear.glsl file include a change in position parameter from a 3-element u16vec3 to a 2-element u16vec2. Differential Revision: [D68113154](https://our.internmc.facebook.com/intern/diff/D68113154/) [ghstack-poisoned]
trviv
added a commit
that referenced
this pull request
Jan 22, 2025
Pull Request resolved: #7728 This diff contains a minor improvement to the q_linear op shader in the Vulkan backend for Executorch. The code changes in the q_8w_linear.glsl file include a change in position parameter from a 3-element u16vec3 to a 2-element u16vec2. ghstack-source-id: 262478289 Differential Revision: [D68113154](https://our.internmc.facebook.com/intern/diff/D68113154/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68113154 |
This diff contains a minor improvement to the q_linear op shader in the Vulkan backend for Executorch. The code changes in the q_8w_linear.glsl file include a change in position parameter from a 3-element u16vec3 to a 2-element u16vec2. Differential Revision: [D68113154](https://our.internmc.facebook.com/intern/diff/D68113154/) [ghstack-poisoned]
trviv
added a commit
that referenced
this pull request
Jan 22, 2025
Pull Request resolved: #7728 This diff contains a minor improvement to the q_linear op shader in the Vulkan backend for Executorch. The code changes in the q_8w_linear.glsl file include a change in position parameter from a 3-element u16vec3 to a 2-element u16vec2. ghstack-source-id: 262587309 Differential Revision: [D68113154](https://our.internmc.facebook.com/intern/diff/D68113154/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68113154 |
This diff contains a minor improvement to the q_linear op shader in the Vulkan backend for Executorch. The code changes in the q_8w_linear.glsl file include a change in position parameter from a 3-element u16vec3 to a 2-element u16vec2. Differential Revision: [D68113154](https://our.internmc.facebook.com/intern/diff/D68113154/) [ghstack-poisoned]
trviv
added a commit
that referenced
this pull request
Jan 23, 2025
Pull Request resolved: #7728 This diff contains a minor improvement to the q_linear op shader in the Vulkan backend for Executorch. The code changes in the q_8w_linear.glsl file include a change in position parameter from a 3-element u16vec3 to a 2-element u16vec2. ghstack-source-id: 262619533 Differential Revision: [D68113154](https://our.internmc.facebook.com/intern/diff/D68113154/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68113154 |
This diff contains a minor improvement to the q_linear op shader in the Vulkan backend for Executorch. The code changes in the q_8w_linear.glsl file include a change in position parameter from a 3-element u16vec3 to a 2-element u16vec2. Differential Revision: [D68113154](https://our.internmc.facebook.com/intern/diff/D68113154/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68113154 |
This diff contains a minor improvement to the q_linear op shader in the Vulkan backend for Executorch. The code changes in the q_8w_linear.glsl file include a change in position parameter from a 3-element u16vec3 to a 2-element u16vec2. Differential Revision: [D68113154](https://our.internmc.facebook.com/intern/diff/D68113154/) [ghstack-poisoned]
trviv
added a commit
that referenced
this pull request
Jan 24, 2025
Pull Request resolved: #7728 This diff contains a minor improvement to the q_linear op shader in the Vulkan backend for Executorch. The code changes in the q_8w_linear.glsl file include a change in position parameter from a 3-element u16vec3 to a 2-element u16vec2. ghstack-source-id: 262853434 Differential Revision: [D68113154](https://our.internmc.facebook.com/intern/diff/D68113154/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68113154 |
This was referenced Jan 24, 2025
121b0b3
into
gh/trivedivivek/45/base
46 of 47 checks passed
trviv
added a commit
that referenced
this pull request
Jan 24, 2025
Pull Request resolved: #7728 This diff contains a minor improvement to the q_linear op shader in the Vulkan backend for Executorch. The code changes in the q_8w_linear.glsl file include a change in position parameter from a 3-element u16vec3 to a 2-element u16vec2. ghstack-source-id: 262853434 Differential Revision: [D68113154](https://our.internmc.facebook.com/intern/diff/D68113154/) Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>
YIWENX14
pushed a commit
that referenced
this pull request
Jan 28, 2025
Pull Request resolved: #7728 This diff contains a minor improvement to the q_linear op shader in the Vulkan backend for Executorch. The code changes in the q_8w_linear.glsl file include a change in position parameter from a 3-element u16vec3 to a 2-element u16vec2. ghstack-source-id: 262853434 Differential Revision: [D68113154](https://our.internmc.facebook.com/intern/diff/D68113154/) Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>
zonglinpeng
pushed a commit
to zonglinpeng/executorch
that referenced
this pull request
Jan 30, 2025
Pull Request resolved: pytorch#7728 This diff contains a minor improvement to the q_linear op shader in the Vulkan backend for Executorch. The code changes in the q_8w_linear.glsl file include a change in position parameter from a 3-element u16vec3 to a 2-element u16vec2. ghstack-source-id: 262853434 Differential Revision: [D68113154](https://our.internmc.facebook.com/intern/diff/D68113154/) Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
Pull Request resolved: pytorch/executorch#7728 This diff contains a minor improvement to the q_linear op shader in the Vulkan backend for Executorch. The code changes in the q_8w_linear.glsl file include a change in position parameter from a 3-element u16vec3 to a 2-element u16vec2. ghstack-source-id: 262403984 Differential Revision: [D68113154](https://our.internmc.facebook.com/intern/diff/D68113154/)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This diff contains a minor improvement to the q_linear op shader in the Vulkan backend for Executorch. The code changes in the q_8w_linear.glsl file include a change in position parameter from a 3-element u16vec3 to a 2-element u16vec2.
Differential Revision: D68113154