[ET-VK] Minor improvement to q_linear op shader.#7932
Merged
Conversation
Pull Request resolved: #7728 This diff contains a minor improvement to the q_linear op shader in the Vulkan backend for Executorch. The code changes in the q_8w_linear.glsl file include a change in position parameter from a 3-element u16vec3 to a 2-element u16vec2. ghstack-source-id: 262853434 Differential Revision: [D68113154](https://our.internmc.facebook.com/intern/diff/D68113154/)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7932
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit f5f5f65 with merge base f73b8cf ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
trviv
approved these changes
Jan 24, 2025
YIWENX14
pushed a commit
that referenced
this pull request
Jan 28, 2025
Pull Request resolved: #7728 This diff contains a minor improvement to the q_linear op shader in the Vulkan backend for Executorch. The code changes in the q_8w_linear.glsl file include a change in position parameter from a 3-element u16vec3 to a 2-element u16vec2. ghstack-source-id: 262853434 Differential Revision: [D68113154](https://our.internmc.facebook.com/intern/diff/D68113154/) Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>
zonglinpeng
pushed a commit
to zonglinpeng/executorch
that referenced
this pull request
Jan 30, 2025
Pull Request resolved: pytorch#7728 This diff contains a minor improvement to the q_linear op shader in the Vulkan backend for Executorch. The code changes in the q_8w_linear.glsl file include a change in position parameter from a 3-element u16vec3 to a 2-element u16vec2. ghstack-source-id: 262853434 Differential Revision: [D68113154](https://our.internmc.facebook.com/intern/diff/D68113154/) Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #7728
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/45/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/45/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/45/orig
@diff-train-skip-merge