[ET-VK] Minor improvements to conv2d pw and dw bounds check.#7815

Merged

facebook-github-bot merged 6 commits intogh/trivedivivek/47/basefrom

gh/trivedivivek/47/head

Jan 27, 2025

Contributor

trviv commented Jan 21, 2025 •

edited

Loading

Stack from ghstack (oldest at bottom):

This diff contains minor improvements to the conv2d pw and dw bounds check in the Vulkan backend for Executorch.

Differential Revision: D68400689


          [ET-VK] Minor improvements to conv2d pw and dw bounds check.

09626eb

This diff contains minor improvements to the conv2d pw and dw bounds check in the Vulkan backend for Executorch.

Differential Revision: [D68400689](https://our.internmc.facebook.com/intern/diff/D68400689/)

[ghstack-poisoned]

pytorch-bot bot commented Jan 21, 2025 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7815

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 3db13d9 with merge base e78ed83 ():

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / unittest / linux / linux-job (gh) (trunk failure)
backends/xnnpack/test/ops/test_add.py::TestAdd::test_qs8_add3
pull / unittest / macos / macos-job (gh) (trunk failure)
backends/xnnpack/test/ops/test_conv1d.py::TestConv1d::test_qs8_conv1d

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot added the CLA Signed label

Contributor

facebook-github-bot commented Jan 21, 2025

This pull request was exported from Phabricator. Differential Revision: D68400689

facebook-github-bot added the fb-exported label

This was referenced Jan 21, 2025

[ET-VK] Minor improvement to q_linear op shader. #7728

Merged

[ET-VK] Using push constants for conv2d pw. #7814

Merged

[ET-VK] Splitting TILE_SIZE to TILE_SIZE_X and TILE_SIZE_Y in conv2d pw. #7816

Merged

[ET-VK] Using shared memory offsetting in conv2d pw and saving ivec3 pos instead of ivec2 to improve performance. #7817

Merged

[ET-VK] Using shared memory to save position in conv2d dw output op. #7818

Open


          Update on "[ET-VK] Minor improvements to conv2d pw and dw bounds check."

cef6b58

This diff contains minor improvements to the conv2d pw and dw bounds check in the Vulkan backend for Executorch.

Differential Revision: [D68400689](https://our.internmc.facebook.com/intern/diff/D68400689/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Jan 22, 2025

This pull request was exported from Phabricator. Differential Revision: D68400689


          Update on "[ET-VK] Minor improvements to conv2d pw and dw bounds check."

673792c

This diff contains minor improvements to the conv2d pw and dw bounds check in the Vulkan backend for Executorch.

Differential Revision: [D68400689](https://our.internmc.facebook.com/intern/diff/D68400689/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Jan 24, 2025

This pull request was exported from Phabricator. Differential Revision: D68400689

trviv mentioned this pull request

[ET-VK] Using shared memory to save position in conv2d dw output op. #7923

Merged

trviv added the topic: not user facing label

This was referenced Jan 24, 2025

[ET-VK] Using push constants for conv2d dw. #7928

Merged

[ET-VK] Using TmpTensor for width packed versions of q_linear op shader to reduce memory usage. #7929

Merged


          Update on "[ET-VK] Minor improvements to conv2d pw and dw bounds check."

f537bea

This diff contains minor improvements to the conv2d pw and dw bounds check in the Vulkan backend for Executorch.

Differential Revision: [D68400689](https://our.internmc.facebook.com/intern/diff/D68400689/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Jan 24, 2025

This pull request was exported from Phabricator. Differential Revision: D68400689

nathanaelsee approved these changes

View reviewed changes


          Update on "[ET-VK] Minor improvements to conv2d pw and dw bounds check."

65c879d

This diff contains minor improvements to the conv2d pw and dw bounds check in the Vulkan backend for Executorch.

Differential Revision: [D68400689](https://our.internmc.facebook.com/intern/diff/D68400689/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Jan 27, 2025

This pull request was exported from Phabricator. Differential Revision: D68400689


          Update on "[ET-VK] Minor improvements to conv2d pw and dw bounds check."

3db13d9

This diff contains minor improvements to the conv2d pw and dw bounds check in the Vulkan backend for Executorch.

Differential Revision: [D68400689](https://our.internmc.facebook.com/intern/diff/D68400689/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Jan 27, 2025

This pull request was exported from Phabricator. Differential Revision: D68400689

facebook-github-bot merged commit ebbe962 into gh/trivedivivek/47/base

44 of 47 checks passed

facebook-github-bot deleted the gh/trivedivivek/47/head branch

January 27, 2025 20:30

facebook-github-bot temporarily deployed to cherry-pick-bot

January 27, 2025 20:30

— with

GitHub Actions Inactive

pytorchbot mentioned this pull request

[ET-VK] Minor improvements to conv2d pw and dw bounds check. #7971

Merged

kirklandsign pushed a commit that referenced this pull request


          [ET-VK] Minor improvements to conv2d pw and dw bounds check.

Pull Request resolved: #7815

This diff contains minor improvements to the conv2d pw and dw bounds check in the Vulkan backend for Executorch.
ghstack-source-id: 263238731
@exported-using-ghexport

Differential Revision: [D68400689](https://our.internmc.facebook.com/intern/diff/D68400689/)

---------

Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>

YIWENX14 pushed a commit that referenced this pull request


          [ET-VK] Minor improvements to conv2d pw and dw bounds check.

5d048e9

Pull Request resolved: #7815

This diff contains minor improvements to the conv2d pw and dw bounds check in the Vulkan backend for Executorch.
ghstack-source-id: 263238731
@exported-using-ghexport

Differential Revision: [D68400689](https://our.internmc.facebook.com/intern/diff/D68400689/)

---------

Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>

zonglinpeng pushed a commit to zonglinpeng/executorch that referenced this pull request


          [ET-VK] Minor improvements to conv2d pw and dw bounds check.

035914f

Pull Request resolved: pytorch#7815

This diff contains minor improvements to the conv2d pw and dw bounds check in the Vulkan backend for Executorch.
ghstack-source-id: 263238731
@exported-using-ghexport

Differential Revision: [D68400689](https://our.internmc.facebook.com/intern/diff/D68400689/)

---------

Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>

kedarnath03 pushed a commit to kedarnath03/executorch that referenced this pull request


          [ET-VK] Minor improvements to conv2d pw and dw bounds check.

bbf3c41

Pull Request resolved: pytorch/executorch#7815

This diff contains minor improvements to the conv2d pw and dw bounds check in the Vulkan backend for Executorch.
ghstack-source-id: 262139045
@exported-using-ghexport

Differential Revision: [D68400689](https://our.internmc.facebook.com/intern/diff/D68400689/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported topic: not user facing