Support build on native Windows x64#7217
Support build on native Windows x64#7217chinazhangchao wants to merge 3 commits intopytorch:mainfrom vortex-captain:win_build_basic
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7217
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a571e16 with merge base 63238ab ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label "release notes: build" |
|
Thank you for this PR! I'll take a look in the next couple of days. @tarun292 please also take a look; I'm not sure if we can assume that all windows users will be able to use clang-cl. |
Thanks for your attention! Windows users can install clang-cl via winget like |
@dbort executorch codebase heavily uses compile flags that MSVS does not support , clang-cl is much easier to make working |
|
clang is part of the Visual Studio installer package. Installing it nothing mere that a single click in the visual studio installer. The cmdline option using winget is simple as well. As long as the build system notifies the user that clang is required I wouldn't consider clang only as blocker for this CL. If MSVC support is really required it still can be added in the long term. |
|
Closing this PR now, as the changes contained in this PR are now merged as a part of the recent Windows support effort i.e. #9198 |
Summary
This PR is the first one of a series of PRs split from #6979 to support for out-of-the-box builds on Windows x64.
./install_requirements.batbuild and installexecutorchpython package successfully, without xnnpack./install_requirements.bat --pybind xnnpackworkexamples/models/llama/Test plan
PR tested by running minimal executor_runner example (https://pytorch.org/executorch/stable/getting-started-setup.html#run-your-program) in the following environment:
Steps:
References
#6979
#4681
#5252
#4899
#5164
#4993