Skip to content

[Build] use timespec_get to get current time#5252

Merged
kirklandsign merged 5 commits intopytorch:mainfrom
python3kgae:timespec_get
Mar 31, 2025
Merged

[Build] use timespec_get to get current time#5252
kirklandsign merged 5 commits intopytorch:mainfrom
python3kgae:timespec_get

Conversation

@python3kgae
Copy link
Contributor

@python3kgae python3kgae commented Sep 10, 2024

Replace clock_gettime with timespec_get which works on Windows as well.

For #4661

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 10, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5252

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 21094a9 with merge base 0342bab (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 10, 2024
@vortex-captain vortex-captain mentioned this pull request Dec 4, 2024
Closed
@chinazhangchao chinazhangchao mentioned this pull request Dec 6, 2024
Closed
@shoumikhin
Copy link
Contributor

shoumikhin commented Mar 17, 2025

@tarun292, @kirklandsign can you take a look please?

@larryliu0820
Copy link
Contributor

larryliu0820 commented Mar 17, 2025

@pytorchbot rebase

@python3kgae @larryliu0820
[Build] use timespec_get to get current time
176f197 
Replace clock_gettime with timespec_get which works on Windows as well.

For pytorch#4661
@swolchok
Copy link
Contributor

swolchok commented Mar 17, 2025

apparently timespec_get is only available in recent versions of Android. confluentinc/librdkafka#3044

swolchok
swolchok suggested changes Mar 17, 2025
View reviewed changes
Copy link
Contributor

@swolchok swolchok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'll need to change this to fix the android failure, feel free to ping me for re-review

@python3kgae
Copy link
Contributor Author

python3kgae commented Mar 22, 2025

you'll need to change this to fix the android failure, feel free to ping me for re-review

Thanks for the feedback.
Updated.

swolchok
swolchok approved these changes Mar 24, 2025
View reviewed changes
extension/llm/runner/util.h Outdated
Comment on lines +72 to +73
// above 29.
#if defined(__ANDROID_API__) && __ANDROID_API__ < 29
Copy link
Contributor

@swolchok swolchok Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment doesn't match the code -- comment says above 29, code says 29 or later

Copy link
Contributor Author

@python3kgae python3kgae Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@kirklandsign
Copy link
Contributor

kirklandsign commented Mar 26, 2025

Thank you!

@kirklandsign kirklandsign merged commit 48de264 into pytorch:main Mar 31, 2025
80 of 81 checks passed
kirklandsign pushed a commit that referenced this pull request Apr 11, 2025
@python3kgae @kirklandsign
[Build] use timespec_get to get current time (#5252)
c6eab01 
Replace clock_gettime with timespec_get which works on Windows as well.

For #4661
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackzhxng jackzhxng Awaiting requested review from jackzhxng

@iseeyuan iseeyuan Awaiting requested review from iseeyuan

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

1 more reviewer

@swolchok swolchok swolchok approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@python3kgae @shoumikhin @larryliu0820 @swolchok @kirklandsign @facebook-github-bot