[Build] Set correct flatcc path for Windows#4993
Closed
python3kgae wants to merge 2 commits intopytorch:mainfrom
Closed
[Build] Set correct flatcc path for Windows#4993python3kgae wants to merge 2 commits intopytorch:mainfrom
python3kgae wants to merge 2 commits intopytorch:mainfrom
Conversation
The binary directory for Windows will have build type like Debug/Release at the end. For pytorch#4661
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4993
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit eec7e96 with merge base 959bb1b ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
@tarun292, @kirklandsign, @Gasoonjia can you take a look please? |
Contributor
|
The changes here are covered by #8970 already. I think we can close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The binary directory for Windows will have build type like Debug/Release at the end.
For #4661