[ET-VK] Rearranging code in permute op shader to reduce heavy math ops and improve performance.#7014
Merged
facebook-github-bot merged 4 commits intogh/trivedivivek/13/basefrom Nov 26, 2024
Conversation
…s and improve performance. The diff rearranges Permute op shader code in executorch vulkan backend to reduce heavy math operations and improve performance. The change also include adding an extension to support explicit arithmetic types and changing the data type of the position variable to u16vec3. Differential Revision: [D66174765](https://our.internmc.facebook.com/intern/diff/D66174765/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7014
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 8c171a0 with merge base 2967302 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66174765 |
This was referenced Nov 21, 2024
nathanaelsee
approved these changes
Nov 26, 2024
…avy math ops and improve performance." The diff rearranges Permute op shader code in executorch vulkan backend to reduce heavy math operations and improve performance. The change also include adding an extension to support explicit arithmetic types and changing the data type of the position variable to u16vec3. Differential Revision: [D66174765](https://our.internmc.facebook.com/intern/diff/D66174765/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66174765 |
…avy math ops and improve performance." The diff rearranges Permute op shader code in executorch vulkan backend to reduce heavy math operations and improve performance. The change also include adding an extension to support explicit arithmetic types and changing the data type of the position variable to u16vec3. Differential Revision: [D66174765](https://our.internmc.facebook.com/intern/diff/D66174765/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66174765 |
…avy math ops and improve performance." The diff rearranges Permute op shader code in executorch vulkan backend to reduce heavy math operations and improve performance. The change also include adding an extension to support explicit arithmetic types and changing the data type of the position variable to u16vec3. Differential Revision: [D66174765](https://our.internmc.facebook.com/intern/diff/D66174765/) [ghstack-poisoned]
trviv
added a commit
that referenced
this pull request
Nov 26, 2024
…s and improve performance. Pull Request resolved: #7014 The diff rearranges Permute op shader code in executorch vulkan backend to reduce heavy math operations and improve performance. The change also include adding an extension to support explicit arithmetic types and changing the data type of the position variable to u16vec3. ghstack-source-id: 255546339 @exported-using-ghexport Differential Revision: [D66174765](https://our.internmc.facebook.com/intern/diff/D66174765/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66174765 |
kirklandsign
pushed a commit
that referenced
this pull request
Nov 26, 2024
…s and improve performance. (#7095) Pull Request resolved: #7014 The diff rearranges Permute op shader code in executorch vulkan backend to reduce heavy math operations and improve performance. The change also include adding an extension to support explicit arithmetic types and changing the data type of the position variable to u16vec3. ghstack-source-id: 255546339 @exported-using-ghexport Differential Revision: [D66174765](https://our.internmc.facebook.com/intern/diff/D66174765/) Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The diff rearranges Permute op shader code in executorch vulkan backend to reduce heavy math operations and improve performance. The change also include adding an extension to support explicit arithmetic types and changing the data type of the position variable to u16vec3.
Differential Revision: D66174765