Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8970
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit fce39dc with merge base 6eee931 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
tarun292
reviewed
Mar 5, 2025
devtools/CMakeLists.txt
Outdated
| ) | ||
|
|
||
| message("Hello") | ||
| message("${CMAKE_GENERATOR}") |
tarun292
reviewed
Mar 5, 2025
| if(WIN32) | ||
| set(RM_COMMAND rmdir /s /q) | ||
| else() | ||
| set(RM_COMMAND rm -rf) |
Contributor
There was a problem hiding this comment.
rm -rf in a cmakefile makes me a little uneasy, why do we need this?
Contributor
Author
There was a problem hiding this comment.
I don't know; rm -rf was being used before my changes. Here I'm simply switching it to use a cmd.exe equivalent for Windows. I can change it to rm -r if that's more reasonable.
Contributor
There was a problem hiding this comment.
ah ok looks like it was there before, so hopefully should be fine i guess
Contributor
Author
cc: @tarun292 |
tarun292
approved these changes
Mar 6, 2025
Contributor
Author
|
test failure is most probably unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is based on #4993 but includes an additional fix to use the correct equivalent of the
rm -rfcommand for Windows.Test plan
Built ExecuTorch for Windows using the following command: