Show archive action on hover with confirm focus#1561
Merged
juliusmarminge merged 2 commits intomainfrom Mar 30, 2026
Merged
Conversation
- Reveal thread archive controls only while hovering or focusing the row - Keep the confirm action accessible after starting archive confirmation - Add coverage for hover hide/show and confirm button behavior
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
- Add isolate to thread rows so the archive control layers correctly - Remove unnecessary z-index from archive confirm affordances
8 tasks
aaditagrawal
added a commit
to aaditagrawal/t3code
that referenced
this pull request
Mar 30, 2026
Integrates upstream changes including: - Refactor terminal manager onto Effect runtime (pingdotgg#1525) - Refactor web orchestration sync to incremental events and isolated recovery (pingdotgg#1560) - Remove redundant add-project cancel button (pingdotgg#1302) - README documentation updates (pingdotgg#1406, pingdotgg#1564, pingdotgg#1565) Conflict resolution across 8 files: adopted upstream's incremental event store architecture, terminal Effect runtime, and batched orchestration effects while preserving fork's multi-provider state.
5 tasks
aaditagrawal
added a commit
to aaditagrawal/t3code
that referenced
this pull request
Mar 31, 2026
Sync fork with upstream/main (post-pingdotgg#1561, 6 commits)
Chrono-byte
pushed a commit
to Chrono-byte/t3code
that referenced
this pull request
Mar 31, 2026
xddinside
referenced
this pull request
in xddinside/t3code
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
bun fmtbun lintbun typecheckbun run testNote
Low Risk
Low risk UI/interaction change limited to sidebar thread rows, plus new browser tests; main risk is minor regressions in hover/focus behavior or keyboard accessibility.
Overview
Updates sidebar thread rows so the archive button is only revealed on hover/focus via CSS (removing React
hoveredThreadIdtracking) and hides thread metadata while the action is shown.When
confirmThreadArchiveis enabled, clicking archive now auto-focuses the confirm button (via stored refs +requestAnimationFrame) and confirmation state is cleared on pointer leave or when the row loses focus.Adds browser test coverage asserting the archive action hides when leaving a row and that the confirm-archive control appears after clicking the archive button (using new
data-testids likethread-row-*,thread-archive-*,thread-archive-confirm-*).Written by Cursor Bugbot for commit 88d88ba. This will update automatically on new commits. Configure here.
Note
Show archive action on thread row hover using CSS and focus confirm button on click
hoveredThreadIdstate entirely.confirmingArchiveThreadIdand focuses the confirm button on the next animation frame; when disabled, it archives immediately.confirmingArchiveThreadIdclears on mouse leave or when focus leaves the thread row viaonBlurCapture.data-testidattributes to thread rows, archive buttons, and confirm buttons, with browser tests covering hover visibility and confirm-on-click behavior.Macroscope summarized 88d88ba.