refactor(web): remove redundant add-project cancel button#1302
Merged
juliusmarminge merged 1 commit intopingdotgg:mainfrom Mar 30, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
eggfriedrice24
approved these changes
Mar 22, 2026
dbaa4a2 to
fc67e4d
Compare
aaditagrawal
added a commit
to aaditagrawal/t3code
that referenced
this pull request
Mar 30, 2026
Integrates upstream changes including: - Refactor terminal manager onto Effect runtime (pingdotgg#1525) - Refactor web orchestration sync to incremental events and isolated recovery (pingdotgg#1560) - Remove redundant add-project cancel button (pingdotgg#1302) - README documentation updates (pingdotgg#1406, pingdotgg#1564, pingdotgg#1565) Conflict resolution across 8 files: adopted upstream's incremental event store architecture, terminal Effect runtime, and batched orchestration effects while preserving fork's multi-provider state.
5 tasks
Chrono-byte
pushed a commit
to Chrono-byte/t3code
that referenced
this pull request
Mar 31, 2026
xddinside
referenced
this pull request
in xddinside/t3code
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Removed the extra inline
Cancelbutton from the add-project form in the sidebar.Why
There is already another cancel button. The add-project toggle button switches into the cancel action when the form is open.
The inline
Cancelbutton duplicates behavior that is already exposed by this add-project toggle. (You can also pressEscto cancel btw)Removing it simplifies the UI and reduces duplicate controls for the same action.
UI Changes
Before:

After:

Checklist
Note
Remove Cancel button from add-project panel in Sidebar
Removes the inline Cancel button from the add-project UI in Sidebar.tsx. Risk: users can no longer dismiss the add-project panel via this button.
Macroscope summarized fc67e4d.
Note
Low Risk
Low risk UI simplification in the sidebar add-project form; main behavioral change is removing one way to cancel/clear errors, relying on the existing toggle button and
Escinstead.Overview
Simplifies the sidebar add-project UI by removing the inline
Cancelbutton from the add-project form inSidebar.tsx.Canceling add-project mode (and clearing
addProjectError) is now done via the existing add-project toggle button (plus icon) or theEscapekey, reducing duplicated controls.Written by Cursor Bugbot for commit fc67e4d. This will update automatically on new commits. Configure here.