fix(TimePicker): scroll dropdown to typed value in safari#7888
Merged
nicolethoen merged 1 commit intopatternfly:mainfrom Sep 1, 2022
Merged
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-7888.surge.sh A11y report: https://patternfly-react-pr-7888-a11y.surge.sh |
thatblindgeye
approved these changes
Aug 29, 2022
Contributor
thatblindgeye
left a comment
There was a problem hiding this comment.
Looks good in Safari, Chromium and Firefox!
In terms of a possible test, I couldn't come up with anything as of yet when attempting to look into things. Even with Cypress (if you really wanted to go there) there's no option for Safari in the browser options you can choose from.
Collaborator
Author
|
@thatblindgeye that's pretty much where I landed on the test front as well, Cypress seems to be working on Safari support but unfortunately they aren't there yet. |
nicolethoen
approved these changes
Sep 1, 2022
Contributor
nicolethoen
left a comment
There was a problem hiding this comment.
I agree it appears to work in chrome, safari, and firefox :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #7747
Additional issues:
I would like to be able to add a test for this bug, but since it's something that only presented in Safari I'm not sure how I would go about that. If anyone has any ideas for that please let me know!
Convenience link: https://patternfly-react-pr-7888.surge.sh/components/time-picker/