Skip to content

fix(TimePicker): scroll dropdown to typed value in safari #7888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolethoen merged 1 commit into from
Sep 1, 2022
Merged

fix(TimePicker): scroll dropdown to typed value in safari #7888

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/react-core/src/components/TimePicker/TimePicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ export class TimePicker extends React.Component<TimePickerProps, TimePickerState
) {
time = `${time}${new Date().getHours() > 11 ? pmSuffix : amSuffix}`;
}
let scrollIndex = this.getOptions().findIndex(option => option.innerText === time);
let scrollIndex = this.getOptions().findIndex(option => option.textContent === time);

// if we found an exact match, scroll to match and return index of match for focus
if (scrollIndex !== -1) {
Expand All @@ -299,7 +299,7 @@ export class TimePicker extends React.Component<TimePickerProps, TimePickerState
}
}
time = `${splitTime[0]}${delimiter}00${amPm}`;
scrollIndex = this.getOptions().findIndex(option => option.innerText === time);
scrollIndex = this.getOptions().findIndex(option => option.textContent === time);
if (scrollIndex !== -1) {
this.scrollToIndex(scrollIndex);
}
Expand Down