feat(core): emit canonical sub-agent activity items - #31299
Merged
Conversation
This was referenced Jul 6, 2026
owenlin0
marked this pull request as ready for review
July 6, 2026 22:14
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fddbaa9ffc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
owenlin0
force-pushed
the
owen/canonical-dynamic-tool-call-items
branch
from
July 7, 2026 03:51
a354d83 to
aac2b79
Compare
owenlin0
force-pushed
the
owen/canonical-sub-agent-activity-items
branch
from
July 7, 2026 03:51
fddbaa9 to
7e9e806
Compare
owenlin0
force-pushed
the
owen/canonical-dynamic-tool-call-items
branch
from
July 7, 2026 03:54
aac2b79 to
1661367
Compare
owenlin0
force-pushed
the
owen/canonical-sub-agent-activity-items
branch
from
July 7, 2026 03:54
7e9e806 to
122f1c9
Compare
owenlin0
force-pushed
the
owen/canonical-dynamic-tool-call-items
branch
from
July 7, 2026 04:31
1661367 to
9036b0a
Compare
owenlin0
force-pushed
the
owen/canonical-sub-agent-activity-items
branch
from
July 7, 2026 15:37
122f1c9 to
3d2cb39
Compare
pakrym-oai
approved these changes
Jul 7, 2026
pakrym-oai
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on #31296 for the canonical-to-legacy event mappings.
Description
This PR makes the MultiAgentV2 spawn, message/follow-up, and interrupt paths emit completed canonical
TurnItem::SubAgentActivityitems instead ofSubAgentActivityEventdirectly.App-server v2 now applies interrupted-agent thread-watch cleanup from the canonical completed item and ignores the mapped legacy activity event.
Why
Sub-agent activity is separate from the v1 collab tool begin/end lifecycle. Keeping it separate makes the v2 watcher side effect reviewable without mixing in the larger collab tool-call migration.
What changed