feat(core): emit canonical command execution items - #31297
Merged
Conversation
This was referenced Jul 6, 2026
owenlin0
marked this pull request as ready for review
July 6, 2026 22:14
pakrym-oai
reviewed
Jul 7, 2026
| ctx.session | ||
| .send_event( | ||
| ctx.turn, | ||
| EventMsg::ExecCommandBegin(ExecCommandBeginEvent { |
Contributor
There was a problem hiding this comment.
shouldn't this be a legacy event?
pakrym-oai
reviewed
Jul 7, 2026
| .lock() | ||
| .await | ||
| .turn_summary | ||
| .command_execution_started |
Contributor
Author
There was a problem hiding this comment.
unfortunately we do, we synthesize a ThreadItem::CommandExecution whenever an approval is requested (user or guardian), so this helps us dedupe
pakrym-oai
approved these changes
Jul 7, 2026
owenlin0
force-pushed
the
owen/canonical-command-execution-items
branch
from
July 7, 2026 03:54
16ac27f to
1ec93f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on #31296 for the canonical-to-legacy event mappings.
Description
This PR makes command execution emit canonical
TurnItem::CommandExecutionlifecycle from both the shell tool path and user/shellcommands.App-server v2 consumes the canonical command items directly and ignores the mapped
ExecCommandBegin/ExecCommandEndcompatibility events, so clients still receive one command item lifecycle.UnifiedExecInteractionstays on the legacy path becauseTerminalInteractionis still the v2 surface for stdin and poll events. Emitting a command item there would render the same wait twice.Why
This is the first live producer migration after the compatibility mappings in #31296. Keeping command execution separate makes the unified exec exception reviewable without mixing in dynamic tools or multi-agent behavior.
What changed