refactor(protocol): map canonical tool items to legacy events - #31296
Merged
Conversation
This was referenced Jul 6, 2026
owenlin0
marked this pull request as ready for review
July 6, 2026 22:12
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e09a5e8db1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
pakrym-oai
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds legacy
EventMsgmappings for theTurnItemtypes introduced in #30282:CommandExecutionDynamicToolCallCollabAgentToolCallSubAgentActivityWhen their producers move to canonical
ItemStarted/ItemCompleted, raw core event consumers can still receive the existing begin/end-style events. The canonical item lifecycle remains the live source of truth.We also record the mapped legacy events in rollout trace so the producer migration preserves the existing tool-runtime trace entries.
Why
This is the compatibility layer for the follow-up producer migrations. Splitting it out first keeps each producer PR small and keeps the legacy mapping in one place.
What changed
TurnItem→ legacyEventMsgmappings inprotocol/src/legacy_events.rs.