🎨 Material 3️⃣

[AlvaroBrey]

• needs ui: more theming utilities (for Files) android-common#7
• change common version to tag
• background and icons on tabs
• background to surface for bottom sheets
• settings activity background color wrong most of the time
• icon coloring on multi-seclect toolbar
• overflow menu tinting on profile toolbar
• adapt color for ripple effect on toolbar MaterialButtons
• fast scrollers color
• account selection dialog: the selected "check" is tinted to old primary
• account info (click on user while in manageaccountsactivity) background is old primary
• pop-up menu background on content as well as overflow menu background on toolbar are still blue, best to go for generic dark/light grey/white tones and theme hard via styles.xml
• markwon markdown rendering not respecting dark/light primary color
• link share details fragment
• backup contacts and calendars fragment
• multi-select (actionmode) color is plain wrong
• preview activity toolbar text color
• fix theming coloring on screenshot tests
• colors are default primary right after login (as FDA doesn't refresh after login)
  • FDA does refresh after login, but the user capabilities aren't fetched yet
    • capabilities are fetched in AuthenticatorActivity but not stored
    • done in e7d6715
• what to do with login/etc screens, and drawer header? it doesn't work very well. see https://github.com/nextcloud/android/tree/m3-firstrun for some attempts
  • Generally we need to discuss what to do with places (like drawer header and login screen) where we used to expect the primary color with no changes.
  • Decided that for now they will be left as is

Fixes #10640, #10643

NOTE FOR REVIEWERS: I suggest enabling "hide whitespace changes" in the github diff for a more pleasant experience

[codecov]

Codecov Report

Merging #10717 (7245e2a) into master (2cbd6d9) will increase coverage by 27.72%.
The diff coverage is 30.97%.

❗ Current head 7245e2a differs from pull request most recent head e9ae7dc. Consider uploading reports for the commit e9ae7dc to get more accurate results

Additional details and impacted files

@@              Coverage Diff              @@
##             master   #10717       +/-   ##
=============================================
+ Coverage      3.25%   30.98%   +27.72%     
- Complexity      419     3220     +2801     
=============================================
  Files           547      538        -9     
  Lines         40738    40475      -263     
  Branches       5624     5628        +4     
=============================================
+ Hits           1327    12542    +11215     
+ Misses        39331    26056    -13275     
- Partials         80     1877     +1797     

Impacted Files	Coverage Δ
...java/com/nextcloud/client/di/ComponentsModule.java	0.00% <ø> (ø)
.../java/com/nextcloud/client/jobs/FilesExportWork.kt	0.00% <0.00%> (ø)
...java/com/nextcloud/client/jobs/NotificationWork.kt	0.00% <0.00%> (ø)
...ava/com/nextcloud/client/logger/ui/LogsActivity.kt	0.00% <0.00%> (ø)
...n/java/com/nextcloud/client/media/PlayerService.kt	0.00% <0.00%> (ø)
.../nextcloud/client/onboarding/WhatsNewActivity.java	0.00% <0.00%> (ø)
...ent/widget/DashboardWidgetConfigurationActivity.kt	0.00% <0.00%> (ø)
.../android/authentication/DeepLinkLoginActivity.java	0.00% <ø> (ø)
...loud/android/datamodel/ThumbnailsCacheManager.java	38.77% <0.00%> (+38.77%)	⬆️
...wncloud/android/files/BootupBroadcastReceiver.java	0.00% <ø> (ø)
... and 395 more

[AndyScherzinger]

Sharing fragment got revamped for m3:

before (M2)	after (M3)

[AlvaroBrey]

@tobiasKaminsky @AndyScherzinger this is finally ready for testing/review. Still pending merge of the common PR and doing a tag release there, before this can be merged.

This ended up, as feared, being a monstrous PR both in terms of amount of commits and modified files. Most changes to existing files are pretty straightforward so I'd recommend focusing on new and deleted files. But specially needed is some smoke testing.

To see a before/after, the easiest way is to use the diff view for the screenshots, which are also updated in this PR.

[AlvaroBrey]

Rebased on master, fixed conflicts and build errors

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10717.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	85	84
Errors	0	0

SpotBugs

Category	Base	New
Bad practice	28	28
Correctness	46	46
Dodgy code	355	353
Internationalization	9	9
Multithreaded correctness	9	9
Performance	58	58
Security	28	28
Total	533	531

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10717.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[nextcloud-android-bot]

master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/6279-IT-master-16-27

[AlvaroBrey]

Time to finally merge this and get it into dev! This took a great deal of effort. Thanks @AndyScherzinger for all your contributions, and also thanks @szaimen, @tobiasKaminsky for the help!

[szaimen]

🎉🎉🎉🎉🎉

[AndyScherzinger]

Whoop Whoop! 🎉

Nice to see this being merged 😎