Skip to content

Commit cbc4154

Browse files
committed
Replace ThemeBarUtils with common themeutils
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
1 parent 206eed3 commit cbc4154

15 files changed

Lines changed: 51 additions & 127 deletions

File tree

app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,7 @@ dependencies {
347347
gplayImplementation "com.google.firebase:firebase-messaging:23.0.7"
348348

349349
// TODO change back to tag before merging
350-
implementation 'com.github.nextcloud.android-common:ui:feature/more-theming-files-SNAPSHOT'
350+
implementation 'com.github.nextcloud.android-common:ui:9bad101de67c312731b7f170b23a4e4cf81633a6'
351351
}
352352

353353
configurations.all {

app/src/main/java/com/nextcloud/client/account/UserAccountManagerImpl.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,7 @@ public boolean exists(Account account) {
145145
@Override
146146
@Nullable
147147
public Account getCurrentAccount() {
148+
Log_OC.d(TAG, "getCurrentAccount"); // TODO debug only, remove
148149
Account[] ocAccounts = getAccounts();
149150
Account defaultAccount = null;
150151

app/src/main/java/com/nextcloud/client/di/ThemeModule.kt

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ package com.nextcloud.client.di
2323
import android.content.Context
2424
import com.nextcloud.android.common.ui.theme.MaterialSchemes
2525
import com.owncloud.android.utils.theme.ThemeAvatarUtils
26-
import com.owncloud.android.utils.theme.ThemeBarUtils
2726
import com.owncloud.android.utils.theme.ThemeButtonUtils
2827
import com.owncloud.android.utils.theme.ThemeCheckableUtils
2928
import com.owncloud.android.utils.theme.ThemeColorUtils
@@ -115,12 +114,6 @@ internal abstract class ThemeModule {
115114
return ThemeButtonUtils()
116115
}
117116

118-
@Provides
119-
@Singleton
120-
fun themeBarUtils(): ThemeBarUtils {
121-
return ThemeBarUtils()
122-
}
123-
124117
@Provides
125118
@Singleton
126119
fun themeTextInputUtils(): ThemeTextInputUtils {

app/src/main/java/com/nextcloud/client/logger/ui/LogsActivity.kt

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,15 +33,17 @@ import com.nextcloud.client.di.ViewModelFactory
3333
import com.owncloud.android.R
3434
import com.owncloud.android.databinding.LogsActivityBinding
3535
import com.owncloud.android.ui.activity.ToolbarActivity
36-
import com.owncloud.android.utils.theme.ThemeBarUtils
36+
import com.owncloud.android.utils.theme.newm3.ViewThemeUtils
3737
import javax.inject.Inject
3838

3939
class LogsActivity : ToolbarActivity() {
4040

4141
@Inject
4242
protected lateinit var viewModelFactory: ViewModelFactory
43+
4344
@Inject
44-
protected lateinit var themeBarUtils: ThemeBarUtils
45+
lateinit var viewThemeUtils: ViewThemeUtils
46+
4547
private lateinit var vm: LogsViewModel
4648
private lateinit var binding: LogsActivityBinding
4749
private lateinit var logsAdapter: LogsAdapter
@@ -66,7 +68,7 @@ class LogsActivity : ToolbarActivity() {
6668
}
6769

6870
findViewById<ProgressBar>(R.id.logs_loading_progress).apply {
69-
themeBarUtils.themeProgressBar(context, this, themeColorUtils)
71+
viewThemeUtils.platform.themeHorizontalProgressBar(this)
7072
}
7173

7274
logsAdapter = LogsAdapter(this)

app/src/main/java/com/owncloud/android/media/MediaControlView.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@
4141
import com.owncloud.android.MainApp;
4242
import com.owncloud.android.R;
4343
import com.owncloud.android.lib.common.utils.Log_OC;
44-
import com.owncloud.android.utils.theme.ThemeBarUtils;
4544
import com.owncloud.android.utils.theme.ThemeColorUtils;
45+
import com.owncloud.android.utils.theme.newm3.ViewThemeUtils;
4646

4747
import java.util.Formatter;
4848
import java.util.Locale;
@@ -74,7 +74,7 @@ public class MediaControlView extends FrameLayout implements OnClickListener, On
7474
@Inject
7575
ThemeColorUtils themeColorUtils;
7676
@Inject
77-
ThemeBarUtils themeBarUtils;
77+
ViewThemeUtils viewThemeUtils;
7878

7979

8080
public MediaControlView(Context context,
@@ -137,10 +137,10 @@ private void initControllerView(View v) {
137137
if (progressBar != null) {
138138
if (progressBar instanceof SeekBar) {
139139
SeekBar seeker = (SeekBar) progressBar;
140-
themeBarUtils.colorHorizontalSeekBar(seeker, getContext(), themeColorUtils);
140+
viewThemeUtils.platform.themeHorizontalSeekBar(seeker);
141141
seeker.setOnSeekBarChangeListener(this);
142142
} else {
143-
themeBarUtils.colorHorizontalProgressBar(progressBar, themeColorUtils.primaryAccentColor(getContext()));
143+
viewThemeUtils.platform.themeHorizontalProgressBar(progressBar);
144144
}
145145
progressBar.setMax(1000);
146146
}

app/src/main/java/com/owncloud/android/ui/activity/DrawerActivity.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -113,8 +113,8 @@
113113
import com.owncloud.android.utils.svg.SvgOrImageBitmapTranscoder;
114114
import com.owncloud.android.utils.svg.SvgOrImageDecoder;
115115
import com.owncloud.android.utils.theme.CapabilityUtils;
116-
import com.owncloud.android.utils.theme.ThemeBarUtils;
117116
import com.owncloud.android.utils.theme.ThemeMenuUtils;
117+
import com.owncloud.android.utils.theme.newm3.ViewThemeUtils;
118118

119119
import org.greenrobot.eventbus.EventBus;
120120
import org.greenrobot.eventbus.Subscribe;
@@ -214,7 +214,7 @@ public abstract class DrawerActivity extends ToolbarActivity
214214
ThemeMenuUtils themeMenuUtils;
215215

216216
@Inject
217-
ThemeBarUtils themeBarUtils;
217+
ViewThemeUtils viewThemeUtils;
218218

219219
/**
220220
* Initializes the drawer, its content and highlights the menu item with the given id. This method needs to be
@@ -300,7 +300,7 @@ private void setupQuotaElement() {
300300
mQuotaProgressBar = (ProgressBar) findQuotaViewById(R.id.drawer_quota_ProgressBar);
301301
mQuotaTextPercentage = (TextView) findQuotaViewById(R.id.drawer_quota_percentage);
302302
mQuotaTextLink = (TextView) findQuotaViewById(R.id.drawer_quota_link);
303-
themeBarUtils.colorProgressBar(mQuotaProgressBar, themeColorUtils.primaryColor(this));
303+
viewThemeUtils.platform.themeHorizontalProgressBar(mQuotaProgressBar);
304304
}
305305

306306
public void updateHeader() {
@@ -702,9 +702,10 @@ private void setQuotaInformation(long usedSpace, long totalSpace, int relative,
702702

703703
mQuotaProgressBar.setProgress(relative);
704704

705-
themeBarUtils.colorProgressBar(mQuotaProgressBar, DisplayUtils.getRelativeInfoColor(this,
706-
relative,
707-
themeColorUtils));
705+
final int color = DisplayUtils.getRelativeInfoColor(this,
706+
relative,
707+
themeColorUtils);
708+
viewThemeUtils.platform.themeHorizontalProgressBar(mQuotaProgressBar, color);
708709

709710
updateQuotaLink();
710711
showQuota(true);

app/src/main/java/com/owncloud/android/ui/activity/UploadListActivity.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@
5656
import com.owncloud.android.ui.adapter.UploadListAdapter;
5757
import com.owncloud.android.ui.decoration.MediaGridItemDecoration;
5858
import com.owncloud.android.utils.FilesSyncHelper;
59+
import com.owncloud.android.utils.theme.newm3.ViewThemeUtils;
5960

6061
import javax.inject.Inject;
6162

@@ -99,6 +100,9 @@ public class UploadListActivity extends FileActivity {
99100
@Inject
100101
LocalBroadcastManager localBroadcastManager;
101102

103+
@Inject
104+
ViewThemeUtils viewThemeUtils;
105+
102106
private UploadListLayoutBinding binding;
103107

104108
public static Intent createIntent(OCFile file, User user, Integer flag, Context context) {
@@ -157,7 +161,7 @@ private void setupContent() {
157161
clock,
158162
themeColorUtils,
159163
themeDrawableUtils,
160-
themeBarUtils);
164+
viewThemeUtils);
161165

162166
final GridLayoutManager lm = new GridLayoutManager(this, 1);
163167
uploadListAdapter.setLayoutManager(lm);

app/src/main/java/com/owncloud/android/ui/adapter/UploadListAdapter.java

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424

2525
package com.owncloud.android.ui.adapter;
2626

27-
import android.accounts.Account;
2827
import android.content.ActivityNotFoundException;
2928
import android.content.Context;
3029
import android.content.Intent;
@@ -65,9 +64,9 @@
6564
import com.owncloud.android.ui.activity.FileActivity;
6665
import com.owncloud.android.utils.DisplayUtils;
6766
import com.owncloud.android.utils.MimeTypeUtil;
68-
import com.owncloud.android.utils.theme.ThemeBarUtils;
6967
import com.owncloud.android.utils.theme.ThemeColorUtils;
7068
import com.owncloud.android.utils.theme.ThemeDrawableUtils;
69+
import com.owncloud.android.utils.theme.newm3.ViewThemeUtils;
7170

7271
import java.io.File;
7372
import java.util.Arrays;
@@ -92,7 +91,7 @@ public class UploadListAdapter extends SectionedRecyclerViewAdapter<SectionedVie
9291
private boolean showUser;
9392
private ThemeColorUtils themeColorUtils;
9493
private ThemeDrawableUtils themeDrawableUtils;
95-
private ThemeBarUtils themeBarUtils;
94+
private final ViewThemeUtils viewThemeUtils;
9695

9796
@Override
9897
public int getSectionCount() {
@@ -174,7 +173,7 @@ public UploadListAdapter(final FileActivity fileActivity,
174173
final Clock clock,
175174
final ThemeColorUtils themeColorUtils,
176175
final ThemeDrawableUtils themeDrawableUtils,
177-
final ThemeBarUtils themeBarUtils) {
176+
final ViewThemeUtils viewThemeUtils) {
178177
Log_OC.d(TAG, "UploadListAdapter");
179178
this.parentActivity = fileActivity;
180179
this.uploadsStorageManager = uploadsStorageManager;
@@ -185,7 +184,7 @@ public UploadListAdapter(final FileActivity fileActivity,
185184
this.clock = clock;
186185
this.themeColorUtils = themeColorUtils;
187186
this.themeDrawableUtils = themeDrawableUtils;
188-
this.themeBarUtils = themeBarUtils;
187+
this.viewThemeUtils = viewThemeUtils;
189188

190189
uploadGroups = new UploadGroup[3];
191190

@@ -280,8 +279,7 @@ public void onBindViewHolder(SectionedViewHolder holder, int section, int relati
280279
String status = getStatusText(item);
281280
switch (item.getUploadStatus()) {
282281
case UPLOAD_IN_PROGRESS:
283-
themeBarUtils.colorHorizontalProgressBar(itemViewHolder.binding.uploadProgressBar,
284-
themeColorUtils.primaryAccentColor(parentActivity));
282+
viewThemeUtils.platform.themeHorizontalProgressBar(itemViewHolder.binding.uploadProgressBar);
285283
itemViewHolder.binding.uploadProgressBar.setProgress(0);
286284
itemViewHolder.binding.uploadProgressBar.setVisibility(View.VISIBLE);
287285

app/src/main/java/com/owncloud/android/ui/fragment/FileDetailFragment.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,9 @@
7272
import com.owncloud.android.ui.events.FavoriteEvent;
7373
import com.owncloud.android.utils.DisplayUtils;
7474
import com.owncloud.android.utils.MimeTypeUtil;
75-
import com.owncloud.android.utils.theme.ThemeBarUtils;
7675
import com.owncloud.android.utils.theme.ThemeColorUtils;
7776
import com.owncloud.android.utils.theme.ThemeLayoutUtils;
77+
import com.owncloud.android.utils.theme.newm3.ViewThemeUtils;
7878

7979
import org.greenrobot.eventbus.EventBus;
8080
import org.greenrobot.eventbus.Subscribe;
@@ -118,7 +118,7 @@ public class FileDetailFragment extends FileFragment implements OnClickListener,
118118
@Inject FileDataStorageManager storageManager;
119119
@Inject ThemeColorUtils themeColorUtils;
120120
@Inject ThemeLayoutUtils themeLayoutUtils;
121-
@Inject ThemeBarUtils themeBarUtils;
121+
@Inject ViewThemeUtils viewThemeUtils;
122122
@Inject BackgroundJobManager backgroundJobManager;
123123

124124
/**
@@ -233,7 +233,7 @@ public View onCreateView(@NonNull LayoutInflater inflater, ViewGroup container,
233233
@Override
234234
public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceState) {
235235
if (getFile() != null && user != null) {
236-
themeBarUtils.colorHorizontalProgressBar(binding.progressBar, themeColorUtils.primaryAccentColor(getContext()));
236+
viewThemeUtils.platform.themeHorizontalProgressBar(binding.progressBar);
237237
progressListener = new ProgressListener(binding.progressBar);
238238
binding.cancelBtn.setOnClickListener(this);
239239
binding.favorite.setOnClickListener(this);

app/src/main/java/com/owncloud/android/ui/preview/FileDownloadFragment.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@
3434
import com.owncloud.android.lib.common.network.OnDatatransferProgressListener;
3535
import com.owncloud.android.lib.common.utils.Log_OC;
3636
import com.owncloud.android.ui.fragment.FileFragment;
37-
import com.owncloud.android.utils.theme.ThemeBarUtils;
3837
import com.owncloud.android.utils.theme.ThemeColorUtils;
38+
import com.owncloud.android.utils.theme.newm3.ViewThemeUtils;
3939

4040
import java.lang.ref.WeakReference;
4141

@@ -63,7 +63,7 @@ public class FileDownloadFragment extends FileFragment implements OnClickListene
6363
private User user;
6464

6565
@Inject ThemeColorUtils themeColorUtils;
66-
@Inject ThemeBarUtils themeBarUtils;
66+
@Inject ViewThemeUtils viewThemeUtils;
6767
public ProgressListener mProgressListener;
6868
private boolean mListening;
6969

@@ -145,7 +145,7 @@ public View onCreateView(LayoutInflater inflater, ViewGroup container,
145145
mView = inflater.inflate(R.layout.file_download_fragment, container, false);
146146

147147
ProgressBar progressBar = mView.findViewById(R.id.progressBar);
148-
themeBarUtils.colorHorizontalProgressBar(progressBar, themeColorUtils.primaryAccentColor(getContext()));
148+
viewThemeUtils.platform.themeHorizontalProgressBar(progressBar);
149149
mProgressListener = new ProgressListener(progressBar);
150150

151151
(mView.findViewById(R.id.cancelBtn)).setOnClickListener(this);

0 commit comments

Comments
 (0)