refactor(theme): remove deprecated ThemeColorUtils and migrate header theming to ColorUtil#16492
Open
joshtrichards wants to merge 5 commits intomasterfrom
Open
refactor(theme): remove deprecated ThemeColorUtils and migrate header theming to ColorUtil#16492joshtrichards wants to merge 5 commits intomasterfrom
joshtrichards wants to merge 5 commits intomasterfrom
Conversation
…ity header and banner colors Update DrawerActivity to use ColorUtil and a unified tone-based contrast check for setting ecosystem icon colors and server name text color, ensuring robust fallback and improved legibility with all server branding themes. Drops reliance on deprecated ThemeColorUtils. Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
a4277db to
748f4f7
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16492.apk |
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Not sure about the fallback colors
And addresses these lint warnings:
Related context: PR #10717
Theming/Drawer Branding PR Test Checklist
Optional:
🖼️ Screenshots
🏁 Checklist