Conversation
Do not use "aux_source_directory" in the build script, but rather list out each file explicitly. In particular this avoids incorrectly including the sample_table.c file in the app build.
Use the UT Assert framework and stubs provided by other modules to perform unit testing on the SAMPLE_APP. This gets 100% line coverage on the current implementation.
Fix #41, Do not use aux_source_directory in sample build script
Fix #8, Add sample app tests
Fix use of CFE_ES_APP_ERROR, replace with current symbol name.
c7dd1e8 to
24a5bdb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #8 and #41
Testing performed
See PR #26 and #42
Bundle CI, see nasa/cFS#58
Expected behavior changes
PR #26, Adds a complete example unit test to the Sample Application.
PR #42, sample_table.c is no longer included within the link of sample_app.so.
System(s) tested on
CI Ubuntu:Bionic
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.
Gerardo E. Cruz-Ortiz, NASA-GSFC