Fix #8, Add sample app tests#26
Merged
astrogeco merged 2 commits intointegration-candidatefrom Mar 25, 2020
Merged
Conversation
4f39222 to
64b5704
Compare
Contributor
Author
skliper
previously requested changes
Dec 17, 2019
Contributor
skliper
left a comment
There was a problem hiding this comment.
Is it possible to replace the #include of the *.c file?
Contributor
|
CCB 20200122 - Discussed, the issue is accessing private members. Meeting standard of not #include .c is higher priority than proper scoping (static) |
This was referenced Jan 22, 2020
0e89595 to
c444468
Compare
Use the UT Assert framework and stubs provided by other modules to perform unit testing on the SAMPLE_APP. This gets 100% line coverage on the current implementation.
c444468 to
a029470
Compare
Contributor
Author
|
The latest commit rebases this to "master" and removes the wrapper, compiling the FSW file directly as part of coverage test. Should be good to go. |
astrogeco
previously requested changes
Mar 18, 2020
We decided to keep the 6.7 comment fix here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fixes #8
Adds a complete example unit test to the Sample Application. Uses the UT assert framework with common stubs provided by CFE and other modules.
Obtains 100% line coverage on the current app implementation.
Testing performed
Build with SIMULATION=native ENABLE_UNIT_TESTS=TRUE
Execute the unit tests per "make test" and confirm correct output
Execute "make lcov" to collect coverage statistics
Verified that the Sample application is included in results and achieves 100% line coverage.
Expected behavior changes
No changes to FSW.
System(s) tested on:
Ubuntu 18.04 LTS 64 bit
Additional context
There is a bug in the application implementation, described in #25. The unit tests actually will fail until this is fixed.
Contributor Info
Joseph Hickey, Vantage Systems, Inc.
Community contributors
You must attach a signed CLA (required for acceptance) or reference one already submitted