Subdomain-restricted variables hanging nodes fix#2099
Merged
roystgnr merged 4 commits intoApr 10, 2019
Conversation
This is a little more readable
This catches a bug much earlier in runtime: when bad constraint equations are created, rather than when they are used.
This turned out to be a red herring in my search for a different bug, but it's not a bad thing to keep double-checking.
If we have a subdomain-restricted variable which is supported on a fine element but *not* supported on a neighboring coarse element, then we do *not* want to try to generate hanging node constraints for that interface. Doing so was giving us OOB reads and garbage DoF IDs.
Member
|
Ignoring whitespace changes the diff isn't all that big, so I'll try and backport to 1.4.1 (#2029) as well? |
Member
Author
|
I'd definitely like that; thanks! This is the fix I told you was coming for a "horribly embarrassing" bug - two heavily used features which break intermittently if used together!?! And it was just dumb luck that I got a nice error message to track down; since the OOB access didn't cause a segfault, I fear the breakage could even cause corrupted data in the worst case. |
jwpeterson
pushed a commit
that referenced
this pull request
Apr 10, 2019
jwpeterson
pushed a commit
that referenced
this pull request
Apr 10, 2019
jwpeterson
pushed a commit
that referenced
this pull request
Apr 10, 2019
jwpeterson
pushed a commit
that referenced
this pull request
Apr 10, 2019
If we have a subdomain-restricted variable which is supported on a fine element but *not* supported on a neighboring coarse element, then we do *not* want to try to generate hanging node constraints for that interface. Doing so was giving us OOB reads and garbage DoF IDs. Backported with the other commits from #2099 with the command. git cherry-pick e9297f1 33466d0 ae5cbc1 de07ffc Refs #2029.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I caught this while working on more unit test coverage for #1938, and it turned out to be a bug in master, not just in the rewrite in that PR. Previously, when an element with a subdomain-restricted variable had a coarser neighbor on which that variable was not supported, garbage constraint equations would be generated. This PR adds asserts which would catch similar bugs earlier and adds a fix for the bug.