Skip to content

Subdomain-restricted variables hanging nodes fix #2099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roystgnr merged 4 commits into from
Apr 10, 2019
Merged

Subdomain-restricted variables hanging nodes fix #2099

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e9297f1
Refactor to reduce indentation
roystgnr Apr 9, 2019
33466d0
Assert that neighbors have the DoFs we want
roystgnr Apr 9, 2019
ae5cbc1
Assert sane constraint dof indices
roystgnr Apr 9, 2019
de07ffc
Don't constrain hanging nodes at variable boundary
roystgnr Apr 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions src/base/dof_map_constraints.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1360,6 +1360,12 @@ void DofMap::add_constraint_row (const dof_id_type dof_number,
if (this->is_constrained_dof(dof_number))
libmesh_error_msg("ERROR: DOF " << dof_number << " was already constrained!");

libmesh_assert_less(dof_number, this->n_dofs());
#ifndef NDEBUG
for (const auto & pr : constraint_row)
libmesh_assert_less(pr.first, this->n_dofs());
#endif

// We don't get insert_or_assign until C++17 so we make do.
std::pair<DofConstraints::iterator, bool> it =
_dof_constraints.insert(std::make_pair(dof_number, constraint_row));
Expand Down Expand Up @@ -2956,7 +2962,10 @@ void DofMap::allgather_recursive_constraints(MeshBase & mesh)
{
DofConstraintRow & row = _dof_constraints[constrained];
for (auto & kv : pushed_keys_vals_to_me[i])
row[kv.first] = kv.second;
{
libmesh_assert_less(kv.first, this->n_dofs());
row[kv.first] = kv.second;
}

const Number primal_rhs = pushed_rhss_to_me[i][max_qoi_num];

Expand Down Expand Up @@ -3684,6 +3693,7 @@ void DofMap::scatter_constraints(MeshBase & mesh)
DofConstraintRow & row = _dof_constraints[constrained];
for (auto & key_val : keys_vals[i])
{
libmesh_assert_less(key_val.first, this->n_dofs());
row[key_val.first] = key_val.second;
}
if (ids_rhss[i].second != Number(0))
Expand Down Expand Up @@ -4180,7 +4190,10 @@ void DofMap::gather_constraints (MeshBase & /*mesh*/,
DofConstraintRow & row = _dof_constraints[constrained];
row.clear();
for (auto & pair : data[i])
row[pair.first] = pair.second;
{
libmesh_assert_less(pair.first, this->n_dofs());
row[pair.first] = pair.second;
}

// And prepare to check for more recursive constraints
unexpanded_dofs.insert(constrained);
Expand Down
Loading