Add newly created channels to the current channel list page#2859
Merged
micahscopes merged 1 commit intolearningequality:hotfixesfrom Jan 22, 2021
Merged
Conversation
jayoshih
approved these changes
Jan 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This seems to fix #2815, the apparent deletion of one old channel upon the creation of a new one.
Issue Addressed (if applicable)
Addresses #2815
Steps to Test
Implementation Notes (optional)
At a high level, how did you implement this?
@jayoshih's recent PR to hotfixes added pagination on the channel list page. This PR ensures that newly created channels get added to the page so that they will be displayed.
Does this introduce any tech-debt items?
I found a whole host of weird symptoms of this that I still don't fully understand. Why, for example, was the newly created channel showing up in place of an old channel? This is something that still baffles me.
There may be more issues here, and I'd suggest a more thorough revisit of the channel list pagination code when things have stabilized a bit.
Checklist