Skip to content

Add newly created channels to the current channel list page#2859

Merged
micahscopes merged 1 commit intolearningequality:hotfixesfrom
micahscopes:add-new-channel-to-page
Jan 22, 2021
Merged

Add newly created channels to the current channel list page#2859
micahscopes merged 1 commit intolearningequality:hotfixesfrom
micahscopes:add-new-channel-to-page

Conversation

@micahscopes
Copy link
Copy Markdown
Contributor

@micahscopes micahscopes commented Jan 22, 2021

Description

This seems to fix #2815, the apparent deletion of one old channel upon the creation of a new one.

Issue Addressed (if applicable)

Addresses #2815

Steps to Test

  • Log into one account
  • Log out and log into another one that has some channels
  • Take note of the channels listed on the channel list page
  • Add a new channel
  • Navigate back to the channel list page
  • Ensure that all of the old channels are there, along with the channel you just created.

Implementation Notes (optional)

At a high level, how did you implement this?

@jayoshih's recent PR to hotfixes added pagination on the channel list page. This PR ensures that newly created channels get added to the page so that they will be displayed.

Does this introduce any tech-debt items?

I found a whole host of weird symptoms of this that I still don't fully understand. Why, for example, was the newly created channel showing up in place of an old channel? This is something that still baffles me.

There may be more issues here, and I'd suggest a more thorough revisit of the channel list pagination code when things have stabilized a bit.

Checklist

  • Are there tests for this change?

@micahscopes micahscopes requested a review from jayoshih January 22, 2021 17:29
@micahscopes micahscopes merged commit c7b9f26 into learningequality:hotfixes Jan 22, 2021
@rtibbles rtibbles added this to the Post Release Stabilization milestone Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Creating a new channel leads to disappearance of previously created channels

3 participants