Added pagination to channel lists#2788
Conversation
Codecov Report
@@ Coverage Diff @@
## hotfixes #2788 +/- ##
============================================
+ Coverage 80.80% 84.83% +4.03%
============================================
Files 281 291 +10
Lines 12659 15256 +2597
============================================
+ Hits 10229 12943 +2714
+ Misses 2430 2313 -117
Continue to review full report at Codecov.
|
just wanna double check to make sure pagination is working
micahscopes
left a comment
There was a problem hiding this comment.
Great work! I tested and both pagination work and display of new channels. It's super smooth now 👍 👍
(just gotta fix linting)
|
|
||
| accept(id) { | ||
| const changes = { accepted: true }; | ||
| return client.patch(window.Urls.invitationDetail(id), changes).then(() => { |
There was a problem hiding this comment.
@jayoshih This seems good for now, but for the future, a "proper" fix for the failing client mock issue is to move this functionality out of the resource and into a vuex action. I can follow up on that after launch.
There was a problem hiding this comment.
I would prefer that we keep it here to keep all the api calls in one place rather than move it due to tests
No description provided.