Skip to content

Added pagination to channel lists#2788

Merged
jayoshih merged 6 commits intolearningequality:hotfixesfrom
jayoshih:channel-pages
Jan 15, 2021
Merged

Added pagination to channel lists#2788
jayoshih merged 6 commits intolearningequality:hotfixesfrom
jayoshih:channel-pages

Conversation

@jayoshih
Copy link
Copy Markdown
Contributor

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 14, 2021

Codecov Report

Merging #2788 (faae9b6) into hotfixes (28587f8) will increase coverage by 4.03%.
The diff coverage is 88.73%.

Impacted file tree graph

@@             Coverage Diff              @@
##           hotfixes    #2788      +/-   ##
============================================
+ Coverage     80.80%   84.83%   +4.03%     
============================================
  Files           281      291      +10     
  Lines         12659    15256    +2597     
============================================
+ Hits          10229    12943    +2714     
+ Misses         2430     2313     -117     
Impacted Files Coverage Δ
contentcuration/contentcuration/decorators.py 56.60% <50.00%> (-37.60%) ⬇️
contentcuration/contentcuration/forms.py 69.06% <72.41%> (+20.61%) ⬆️
...ntentcuration/contentcuration/db/models/manager.py 93.49% <93.33%> (-6.51%) ⬇️
contentcuration/contentcuration/api.py 92.06% <100.00%> (+1.43%) ⬆️
...tentcuration/contentcuration/context_processors.py 100.00% <100.00%> (ø)
...tcuration/contentcuration/db/models/expressions.py 93.33% <100.00%> (-6.67%) ⬇️
...entcuration/contentcuration/db/models/functions.py 100.00% <100.00%> (ø)
...ation/contentcuration/tests/test_rest_framework.py 36.93% <0.00%> (-63.07%) ⬇️
contentcuration/contentcuration/utils/format.py 21.05% <0.00%> (-49.54%) ⬇️
contentcuration/contentcuration/utils/cache.py 31.70% <0.00%> (-31.93%) ⬇️
... and 172 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 013edde...e4a65b4. Read the comment docs.

@jayoshih jayoshih requested a review from micahscopes January 14, 2021 23:12
micahscopes
micahscopes previously approved these changes Jan 15, 2021
Copy link
Copy Markdown
Contributor

@micahscopes micahscopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@micahscopes micahscopes dismissed their stale review January 15, 2021 03:12

just wanna double check to make sure pagination is working

@micahscopes micahscopes self-requested a review January 15, 2021 03:16
Copy link
Copy Markdown
Contributor

@micahscopes micahscopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I tested and both pagination work and display of new channels. It's super smooth now 👍 👍

(just gotta fix linting)


accept(id) {
const changes = { accepted: true };
return client.patch(window.Urls.invitationDetail(id), changes).then(() => {
Copy link
Copy Markdown
Contributor

@micahscopes micahscopes Jan 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jayoshih This seems good for now, but for the future, a "proper" fix for the failing client mock issue is to move this functionality out of the resource and into a vuex action. I can follow up on that after launch.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer that we keep it here to keep all the api calls in one place rather than move it due to tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants