Skip to content

PluginE2E: Move away from networkIdle - #1746

Merged
jackw merged 23 commits into
mainfrom
jackandhugo/plugine2e-latest-playwright
May 5, 2025
Merged

PluginE2E: Move away from networkIdle#1746
jackw merged 23 commits into
mainfrom
jackandhugo/plugine2e-latest-playwright

Conversation

@jackw

@jackw jackw commented Apr 23, 2025

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:

The last 2 minor releases of playwright have caused multiple issues (#1606 , #1728 , #1740 , #1741) with plugin-e2e due to changes with using chromiums headless browser and workers picking up events in different ways. This is mainly surfaced with timeouts due to networkIdle being used across all the plugin-e2e page models to wait for a page to load when navigating.

This PR switches networkIdle out for load (which is the default), fixes up any of the issues we can easily identify from the tests in this repo, and continues to allow developers to set the waitUntil property as they see fit.

Once we're confident these tests are not flakey we'll move on to testing a canary build of plugin-e2e in Grafana before merging.

Which issue(s) this PR fixes:

Fixes #1734
Fixes #1745

Special notes for your reviewer:

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @grafana/plugin-e2e@2.0.0-canary.1746.14835096080.0
# or 
yarn add @grafana/plugin-e2e@2.0.0-canary.1746.14835096080.0

@jackw jackw added minor plugin-e2e related to the plugin-e2e package labels Apr 23, 2025
@jackw
jackw requested review from a team, Ukochka, andresmgot, s4kh and wbrowne April 23, 2025 14:01
@github-actions

github-actions Bot commented Apr 23, 2025

Copy link
Copy Markdown
Contributor

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new major release.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

@jackw jackw moved this from 📬 Triage to 🧑‍💻 In development in Grafana Catalog Team Apr 23, 2025
@jackw jackw mentioned this pull request Apr 23, 2025
@hugohaggmark
hugohaggmark force-pushed the jackandhugo/plugine2e-latest-playwright branch from 6ba2324 to 56a26e6 Compare April 24, 2025 06:46
@jackw jackw added major and removed minor labels Apr 24, 2025

@andresmgot andresmgot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a couple of nits

Comment thread packages/plugin-e2e/src/models/pages/AlertRuleEditPage.ts Outdated
@github-project-automation github-project-automation Bot moved this from 🧑‍💻 In development to 🔬 In review in Grafana Catalog Team Apr 24, 2025
@jackw jackw self-assigned this May 2, 2025
@jackw jackw changed the title PluginE2E: Move away from networkIdle PluginE2E: Move away from networkIdle May 5, 2025
@jackw
jackw force-pushed the jackandhugo/plugine2e-latest-playwright branch from e0c5a2f to 49df38c Compare May 5, 2025 11:10
@github-actions

github-actions Bot commented May 5, 2025

Copy link
Copy Markdown
Contributor

Playwright test results

Image Name Version Result Report
grafana-dev 12.1.0-241686
grafana-enterprise 11.6.1
grafana-enterprise 11.3.6
grafana-enterprise 10.2.9
grafana-enterprise 9.2.20
grafana-enterprise 8.5.27
Troubleshooting

404 when clicking on View report

By default, the deploy-report-pages Action deploys reports to the gh-pages branch. However, you need to take an extra step to ensure that GitHub Pages can build and serve the site from this branch. To do so:

  1. Go to the Settings tab of your repository.
  2. In the left-hand sidebar, click on Pages.
  3. Under Source, select Deploy from a branch, then choose the gh-pages branch.

This action needs to be completed manually in order for your GitHub Pages site to be built and accessible from the gh-pages branch. Once configured, GitHub will automatically build and serve the site whenever new reports are deployed.

@jackw
jackw merged commit f95b048 into main May 5, 2025
@jackw
jackw deleted the jackandhugo/plugine2e-latest-playwright branch May 5, 2025 12:19
@github-project-automation github-project-automation Bot moved this from 🔬 In review to 🚀 Shipped in Grafana Catalog Team May 5, 2025
@grafana-plugins-platform-bot

Copy link
Copy Markdown
Contributor

🚀 PR was released in @grafana/plugin-e2e@2.0.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin-e2e related to the plugin-e2e package

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

e2e: waiting until "networkidle" error Plugin E2E: Move away from waitUntil: 'networkidle'

3 participants