PluginE2E: Move away from networkIdle - #1746
Merged
Merged
Conversation
Contributor
Closed
3 tasks
hugohaggmark
force-pushed
the
jackandhugo/plugine2e-latest-playwright
branch
from
April 24, 2025 06:46
6ba2324 to
56a26e6
Compare
…-latest-playwright
andresmgot
approved these changes
Apr 24, 2025
andresmgot
left a comment
Contributor
There was a problem hiding this comment.
LGTM, a couple of nits
5 tasks
networkIdle
jackw
force-pushed
the
jackandhugo/plugine2e-latest-playwright
branch
from
May 5, 2025 11:10
e0c5a2f to
49df38c
Compare
Contributor
Playwright test results
Troubleshooting404 when clicking on
|
Contributor
|
🚀 PR was released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The last 2 minor releases of playwright have caused multiple issues (#1606 , #1728 , #1740 , #1741) with plugin-e2e due to changes with using chromiums headless browser and workers picking up events in different ways. This is mainly surfaced with timeouts due to
networkIdlebeing used across all the plugin-e2e page models to wait for a page to load when navigating.This PR switches
networkIdleout forload(which is the default), fixes up any of the issues we can easily identify from the tests in this repo, and continues to allow developers to set thewaitUntilproperty as they see fit.Once we're confident these tests are not flakey we'll move on to testing a canary build of plugin-e2e in Grafana before merging.
Which issue(s) this PR fixes:
Fixes #1734
Fixes #1745
Special notes for your reviewer:
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @grafana/plugin-e2e@2.0.0-canary.1746.14835096080.0 # or yarn add @grafana/plugin-e2e@2.0.0-canary.1746.14835096080.0