Skip to content

fix: fixes playwright upgrade - #1741

Merged
hugohaggmark merged 3 commits into
mainfrom
hugoh/fix-for-playwright-1.52.0
Apr 22, 2025
Merged

fix: fixes playwright upgrade#1741
hugohaggmark merged 3 commits into
mainfrom
hugoh/fix-for-playwright-1.52.0

Conversation

@hugohaggmark

@hugohaggmark hugohaggmark commented Apr 22, 2025

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
This PR in Playwright made our previous fix here obsolete. So this PR tries to solve this by using the "old" channel as described here. Again we should invest some time looking into ways to remove the networkidle.

Which issue(s) this PR fixes:

Fixes #1733

Special notes for your reviewer:

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @grafana/create-plugin@5.19.7-canary.1741.14593361363.0
npm install @grafana/plugin-e2e@1.19.8-canary.1741.14593361363.0
# or 
yarn add @grafana/create-plugin@5.19.7-canary.1741.14593361363.0
yarn add @grafana/plugin-e2e@1.19.8-canary.1741.14593361363.0

@github-actions

github-actions Bot commented Apr 22, 2025

Copy link
Copy Markdown
Contributor

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new patch release.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

@hugohaggmark hugohaggmark added release type/bug Something isn't working labels Apr 22, 2025
@hugohaggmark hugohaggmark moved this from 📬 Triage to 🔬 In review in Grafana Catalog Team Apr 22, 2025
@hugohaggmark
hugohaggmark requested a review from jackw April 22, 2025 09:08
@hugohaggmark
hugohaggmark marked this pull request as ready for review April 22, 2025 09:18
@hugohaggmark
hugohaggmark requested review from a team, oshirohugo, wbrowne and xnyo April 22, 2025 09:18

@jackw jackw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@github-actions

Copy link
Copy Markdown
Contributor

Playwright test results

Image Name Version Result Report
grafana-dev 12.0.0-239207
grafana-enterprise 11.6.0
grafana-enterprise 11.3.5
grafana-enterprise 10.2.9
grafana-enterprise 9.2.20
grafana-enterprise 8.5.27
Troubleshooting

404 when clicking on View report

By default, the deploy-report-pages Action deploys reports to the gh-pages branch. However, you need to take an extra step to ensure that GitHub Pages can build and serve the site from this branch. To do so:

  1. Go to the Settings tab of your repository.
  2. In the left-hand sidebar, click on Pages.
  3. Under Source, select Deploy from a branch, then choose the gh-pages branch.

This action needs to be completed manually in order for your GitHub Pages site to be built and accessible from the gh-pages branch. Once configured, GitHub will automatically build and serve the site whenever new reports are deployed.

@hugohaggmark
hugohaggmark merged commit be0b042 into main Apr 22, 2025
@hugohaggmark
hugohaggmark deleted the hugoh/fix-for-playwright-1.52.0 branch April 22, 2025 11:23
@github-project-automation github-project-automation Bot moved this from 🔬 In review to 🚀 Shipped in Grafana Catalog Team Apr 22, 2025
@grafana-plugins-platform-bot

Copy link
Copy Markdown
Contributor

🚀 PR was released in @grafana/create-plugin@5.19.7, @grafana/plugin-e2e@1.19.8 🚀

@mikhail-vl

Copy link
Copy Markdown

@hugohaggmark We still have the timeout issue using the latest versions of e2e and playwrite/test packages: https://github.com/VolkovLabs/business-table/actions/runs/14595179556/job/40939250443

@hugohaggmark

hugohaggmark commented Apr 23, 2025

Copy link
Copy Markdown
Contributor Author

@hugohaggmark We still have the timeout issue using the latest versions of e2e and playwrite/test packages: https://github.com/VolkovLabs/business-table/actions/runs/14595179556/job/40939250443

Thanks for reporting here 🙌 @mikhail-vl , I tried running the same steps locally in your repo and I couldn't reproduce it 😞 . Also it seems like not all your runs were red so it would be awesome if you could create a proper issue with repro steps so we can have a look at it. Thank you 🙏

@vitPinchuk

Copy link
Copy Markdown

@hugohaggmark
I created a separate issue with a description
#1745
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Bug: Test timeout while setting up "dashboardPage" wait until "networkidle"

4 participants