You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What this PR does / why we need it:
This PR in Playwright made our previous fixhere obsolete. So this PR tries to solve this by using the "old" channel as described here. Again we should invest some time looking into ways to remove the networkidle.
Hello! 👋 This repository uses Auto for releasing packages using PR labels.
✨ This PR can be merged and will trigger a new patch release. NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.
By default, the deploy-report-pages Action deploys reports to the gh-pages branch. However, you need to take an extra step to ensure that GitHub Pages can build and serve the site from this branch. To do so:
Go to the Settings tab of your repository.
In the left-hand sidebar, click on Pages.
Under Source, select Deploy from a branch, then choose the gh-pages branch.
This action needs to be completed manually in order for your GitHub Pages site to be built and accessible from the gh-pages branch. Once configured, GitHub will automatically build and serve the site whenever new reports are deployed.
Thanks for reporting here 🙌 @mikhail-vl , I tried running the same steps locally in your repo and I couldn't reproduce it 😞 . Also it seems like not all your runs were red so it would be awesome if you could create a proper issue with repro steps so we can have a look at it. Thank you 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR in Playwright made our previous fix here obsolete. So this PR tries to solve this by using the "old" channel as described here. Again we should invest some time looking into ways to remove the
networkidle.Which issue(s) this PR fixes:
Fixes #1733
Special notes for your reviewer:
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @grafana/create-plugin@5.19.7-canary.1741.14593361363.0 npm install @grafana/plugin-e2e@1.19.8-canary.1741.14593361363.0 # or yarn add @grafana/create-plugin@5.19.7-canary.1741.14593361363.0 yarn add @grafana/plugin-e2e@1.19.8-canary.1741.14593361363.0