Skip to content

Plugin e2e: fix color picker selector - #2017

Merged
jackw merged 3 commits into
mainfrom
jackw/fix-plugin-e2e-color-picker
Aug 7, 2025
Merged

Plugin e2e: fix color picker selector#2017
jackw merged 3 commits into
mainfrom
jackw/fix-plugin-e2e-color-picker

Conversation

@jackw

@jackw jackw commented Aug 7, 2025

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:

Spec tests for Grafana versions 11.4.1 -> 11.4.7 are failing on color picker custom tab selection. (Failing run example)

This PR aligns the version checks with changes made to e2e-selectors in this PR to fix this issue.

Additionally I've aligned the goTo specs with the implementation as we no longer use waitUntil: 'networkIdle'. (associated PR).

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @grafana/plugin-e2e@2.1.8-canary.2017.16804424217.0
# or 
yarn add @grafana/plugin-e2e@2.1.8-canary.2017.16804424217.0

@jackw jackw self-assigned this Aug 7, 2025
@jackw
jackw requested review from a team and s4kh August 7, 2025 12:19
@jackw jackw added the patch label Aug 7, 2025
@jackw
jackw requested review from andresmgot and wbrowne August 7, 2025 12:19
@jackw jackw added the release label Aug 7, 2025
@github-actions

github-actions Bot commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new patch release.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

@github-project-automation github-project-automation Bot moved this from 📬 Triage to 🔬 In review in Grafana Catalog Team Aug 7, 2025
@github-actions

github-actions Bot commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

Playwright test results

Image Name Version Result Report
grafana-dev 12.2.0-257787
grafana-enterprise 12.1.0
grafana-enterprise 11.4.7
grafana-enterprise 10.3.12
grafana-enterprise 9.3.16
grafana-enterprise 8.5.27
Troubleshooting

404 when clicking on View report

By default, the deploy-report-pages Action deploys reports to the gh-pages branch. However, you need to take an extra step to ensure that GitHub Pages can build and serve the site from this branch. To do so:

  1. Go to the Settings tab of your repository.
  2. In the left-hand sidebar, click on Pages.
  3. Under Source, select Deploy from a branch, then choose the gh-pages branch.

This action needs to be completed manually in order for your GitHub Pages site to be built and accessible from the gh-pages branch. Once configured, GitHub will automatically build and serve the site whenever new reports are deployed.

@jackw
jackw merged commit f0af062 into main Aug 7, 2025
38 of 40 checks passed
@jackw
jackw deleted the jackw/fix-plugin-e2e-color-picker branch August 7, 2025 12:58
@github-project-automation github-project-automation Bot moved this from 🔬 In review to 🚀 Shipped in Grafana Catalog Team Aug 7, 2025
@grafana-plugins-platform-bot

Copy link
Copy Markdown
Contributor

🚀 PR was released in @grafana/plugin-e2e@2.1.8 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants