Plugin e2e: fix color picker selector - #2017
Merged
Merged
Conversation
Contributor
andresmgot
approved these changes
Aug 7, 2025
Contributor
Playwright test results
Troubleshooting404 when clicking on
|
Contributor
|
🚀 PR was released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Spec tests for Grafana versions 11.4.1 -> 11.4.7 are failing on color picker custom tab selection. (Failing run example)
This PR aligns the version checks with changes made to e2e-selectors in this PR to fix this issue.
Additionally I've aligned the goTo specs with the implementation as we no longer use
waitUntil: 'networkIdle'. (associated PR).Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @grafana/plugin-e2e@2.1.8-canary.2017.16804424217.0 # or yarn add @grafana/plugin-e2e@2.1.8-canary.2017.16804424217.0