fix (regression tests): make datastore queries strongly consistent #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regression/datastore.js
Outdated
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
The previous tests were flaky because based on eventually consistent queries. The new tests use only ancestor queries, that are strongly consistent.
b057b5b to
e633edf
Compare
Contributor
Author
|
Done (squashed to avoid leaving traces of my bad commits :) ) |
Contributor
|
Perfect! Thanks! Merging. PS: Github knows. 👀 |
Contributor
|
... will merge after tests run ... |
ryanseys
added a commit
that referenced
this pull request
Oct 23, 2014
fix (regression tests): make datastore queries strongly consistent
dhermes
added a commit
to dhermes/google-cloud-python
that referenced
this pull request
Oct 23, 2014
Integrates changes from googleapis/google-cloud-node#267
dhermes
added a commit
to dhermes/google-cloud-python
that referenced
this pull request
Oct 23, 2014
Integrates changes from googleapis/google-cloud-node#267
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Sep 16, 2022
sofisl
pushed a commit
that referenced
this pull request
Sep 27, 2022
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 5, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 5, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 8, 2022
This was referenced Oct 11, 2022
sofisl
pushed a commit
that referenced
this pull request
Oct 11, 2022
* fix(docs): reference docs should link to section of googleapis.dev with API reference * fix(docs): make anchors work in jsdoc
sofisl
pushed a commit
that referenced
this pull request
Oct 12, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
* fix(docs): reference docs should link to section of googleapis.dev with API reference * fix(docs): make anchors work in jsdoc
sofisl
pushed a commit
that referenced
this pull request
Nov 9, 2022
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
sofisl
pushed a commit
that referenced
this pull request
Nov 17, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Jan 26, 2023
PiperOrigin-RevId: 429098186 Source-Link: googleapis/googleapis@e75c527 Source-Link: googleapis/googleapis-gen@6114713 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNjExNDcxMzMzODE4Zjg4ZjY2YmZlMjRhYzk3ZDIwNjRjZTBiNTJhZCJ9
4 tasks
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Sep 13, 2023
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Sep 14, 2023
* updated CHANGELOG.md * updated package.json * updated samples/package.json
4 tasks
miguelvelezsa
pushed a commit
that referenced
this pull request
Jul 23, 2025
miguelvelezsa
pushed a commit
that referenced
this pull request
Jan 14, 2026
The system tests for error reporting were still not safe to run concurrently. The issue is that at the end we were deleting all events (there is no API to delete events selectively, AFAICT). This meant that concurrent executions of the system tests against the same project could clobber anothers logged errors. This is consistent with the observed timeouts looking for events to show up. Fixes: #267
GautamSharda
pushed a commit
that referenced
this pull request
Jan 14, 2026
* fix(build): fix system key decryption * Revert "chore: update key for system tests (#265)" This reverts commit 845a3f4600907b593110c1cb4ff898c9699582db.
GautamSharda
pushed a commit
that referenced
this pull request
Jan 14, 2026
GautamSharda
pushed a commit
that referenced
this pull request
Jan 15, 2026
* fix(build): fix system key decryption * Revert "chore: update key for system tests (#265)" This reverts commit 845a3f4600907b593110c1cb4ff898c9699582db.
GautamSharda
pushed a commit
that referenced
this pull request
Jan 20, 2026
4 tasks
miguelvelezsa
pushed a commit
that referenced
this pull request
Jan 21, 2026
The system tests for error reporting were still not safe to run concurrently. The issue is that at the end we were deleting all events (there is no API to delete events selectively, AFAICT). This meant that concurrent executions of the system tests against the same project could clobber anothers logged errors. This is consistent with the observed timeouts looking for events to show up. Fixes: #267
GautamSharda
pushed a commit
that referenced
this pull request
Jan 21, 2026
4 tasks
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Jan 27, 2026
This was referenced Jan 27, 2026
sofisl
pushed a commit
that referenced
this pull request
Jan 27, 2026
This was referenced Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous tests were flaky because based on eventually consistent queries.
The new tests use only ancestor queries, that are strongly consistent.