-
Notifications
You must be signed in to change notification settings - Fork 641
fix (docs): remove warning for storage bucket existence. #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Needs to be removed from README too. Can you make that change as well? Thanks. |
Before 0.9.0 it was not possible to create a bucket using the library, so it had to be done by other means. Starting from 0.9.0 it is possible, so we can remove this warning.
94ba721 to
327d789
Compare
Contributor
Author
|
@ryanseys done ( I squashed the additional change). |
ryanseys
added a commit
that referenced
this pull request
Oct 21, 2014
fix (docs): remove warning for storage bucket existence.
Contributor
|
Thanks! |
chingor13
pushed a commit
that referenced
this pull request
Aug 22, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Sep 16, 2022
sofisl
pushed a commit
that referenced
this pull request
Sep 27, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 5, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 5, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 8, 2022
This was referenced Oct 11, 2022
sofisl
pushed a commit
that referenced
this pull request
Oct 12, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@types/mocha](https://togithub.com/DefinitelyTyped/DefinitelyTyped) | [`^8.0.0` -> `^9.0.0`](https://renovatebot.com/diffs/npm/@types%2fmocha/8.2.3/9.1.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: "after 9am and before 3pm" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-monitoring-dashboards).
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 9, 2022
This was referenced Nov 9, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 10, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Sep 14, 2023
4 tasks
miguelvelezsa
pushed a commit
that referenced
this pull request
Jul 23, 2025
GautamSharda
pushed a commit
that referenced
this pull request
Jan 14, 2026
GautamSharda
pushed a commit
that referenced
this pull request
Jan 14, 2026
* fix(build): fix system key decryption * Revert "chore: update key for system tests (#265)" This reverts commit 845a3f4600907b593110c1cb4ff898c9699582db.
GautamSharda
pushed a commit
that referenced
this pull request
Jan 14, 2026
1. The test timeout was not effectively applied. 2. All of the tests needed a longer timeout rather than just the error reporting ones. 3. The error-reporting tests would race with a concurrent execution of the tests in the CI because they were logging and polling against the same service. Uniquify the service name.
GautamSharda
pushed a commit
that referenced
this pull request
Jan 15, 2026
GautamSharda
pushed a commit
that referenced
this pull request
Jan 15, 2026
* fix(build): fix system key decryption * Revert "chore: update key for system tests (#265)" This reverts commit 845a3f4600907b593110c1cb4ff898c9699582db.
GautamSharda
pushed a commit
that referenced
this pull request
Jan 20, 2026
1. The test timeout was not effectively applied. 2. All of the tests needed a longer timeout rather than just the error reporting ones. 3. The error-reporting tests would race with a concurrent execution of the tests in the CI because they were logging and polling against the same service. Uniquify the service name.
4 tasks
GautamSharda
pushed a commit
that referenced
this pull request
Jan 21, 2026
1. The test timeout was not effectively applied. 2. All of the tests needed a longer timeout rather than just the error reporting ones. 3. The error-reporting tests would race with a concurrent execution of the tests in the CI because they were logging and polling against the same service. Uniquify the service name.
4 tasks
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Jan 27, 2026
This was referenced Jan 27, 2026
sofisl
pushed a commit
that referenced
this pull request
Jan 27, 2026
This was referenced Jan 27, 2026
miguelvelezsa
pushed a commit
that referenced
this pull request
Jan 28, 2026
This was referenced Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before 0.9.0 it was not possible to create a bucket using the library,
so it had to be done by other means.
Starting from 0.9.0 it is possible, so we can remove this warning.