remove bucket env var req. & stop deleting all buckets #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7464e17 to
c05aaa1
Compare
Contributor
Author
|
PTAL |
regression/storage.js
Outdated
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
This looks good to me. @silvolu might like to take a second look, however. |
Contributor
|
Good to go. |
silvolu
added a commit
that referenced
this pull request
Nov 4, 2014
remove bucket env var req. & stop deleting all buckets
sofisl
pushed a commit
that referenced
this pull request
Sep 27, 2022
4 tasks
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 11, 2022
sofisl
pushed a commit
that referenced
this pull request
Oct 12, 2022
This was referenced Oct 12, 2022
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 9, 2022
This was referenced Nov 9, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 10, 2022
This was referenced Nov 10, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 10, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 10, 2022
sofisl
pushed a commit
that referenced
this pull request
Jan 10, 2023
sofisl
pushed a commit
that referenced
this pull request
Jan 24, 2023
sofisl
pushed a commit
that referenced
this pull request
Jan 25, 2023
sofisl
pushed a commit
that referenced
this pull request
Jan 26, 2023
…rm v1 endpoint.proto (#275) * feat: add PredictRequestResponseLoggingConfig to Endpoint in aiplatform v1 endpoint.proto PiperOrigin-RevId: 433794371 Source-Link: googleapis/googleapis@e0f0642 Source-Link: googleapis/googleapis-gen@3afc3ec Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiM2FmYzNlYzE4ZTc5NWM4NTkyMzFhMmMwZjhlZjE3MmE2NTA1NmUwZCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Sep 14, 2023
4 tasks
miguelvelezsa
pushed a commit
that referenced
this pull request
Jul 23, 2025
miguelvelezsa
pushed a commit
that referenced
this pull request
Jan 14, 2026
The system tests for error reporting were still not safe to run concurrently. The issue is that at the end we were deleting all events (there is no API to delete events selectively, AFAICT). This meant that concurrent executions of the system tests against the same project could clobber anothers logged errors. This is consistent with the observed timeouts looking for events to show up. Fixes: #267
GautamSharda
pushed a commit
that referenced
this pull request
Jan 14, 2026
* The timeout used for waiting for the API to report an error event has been increased. * The system tests only poll for error events for a specific service and version. * The page size has been increased when requesting reported errors. * Increase polling timeout to avoid using the API too much to hit quota exceeded errors. * Error items are not deleted after the test. This is needed to avoid conflicting with concurrent runs of the system test because it is not possible to delete error items only associated with a particular test.
GautamSharda
pushed a commit
that referenced
this pull request
Jan 15, 2026
* The timeout used for waiting for the API to report an error event has been increased. * The system tests only poll for error events for a specific service and version. * The page size has been increased when requesting reported errors. * Increase polling timeout to avoid using the API too much to hit quota exceeded errors. * Error items are not deleted after the test. This is needed to avoid conflicting with concurrent runs of the system test because it is not possible to delete error items only associated with a particular test.
4 tasks
miguelvelezsa
pushed a commit
that referenced
this pull request
Jan 21, 2026
The system tests for error reporting were still not safe to run concurrently. The issue is that at the end we were deleting all events (there is no API to delete events selectively, AFAICT). This meant that concurrent executions of the system tests against the same project could clobber anothers logged errors. This is consistent with the observed timeouts looking for events to show up. Fixes: #267
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Jan 27, 2026
This was referenced Jan 27, 2026
sofisl
pushed a commit
that referenced
this pull request
Jan 27, 2026
This was referenced Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #270
fixes #271