Upgrade Homepage by EliasVal · Pull Request #412 · game-ci/documentation

EliasVal · 2023-08-21T22:29:49Z

Changes

(+ Merged #407)

Resolves #411, but not ready yet. Opened PR to allow maintainers to see progress.
Resolves #410

Checklist

Read the contribution guide and accept the
code of conduct
Readme (updated or not needed)
Tests (added, updated or not needed)

…rameters not available in v2 from v2 docs.

github-actions · 2023-08-21T22:30:02Z

EliasVal · 2023-08-21T23:44:04Z

Upgraded the Get Started section!
I also moved it up since the first thing people usually want to know is how to start using GameCI instead of reading all about it.

- Upgraded getting-started.tsx to use company SVGs instead of text - Moved getting-started.tsx section up - Updated node16 references to node18 in .md files

EliasVal · 2023-08-22T11:38:50Z

Resolved #410 :)

It's not entirely finished, I have to rebuild the builds-table to ditch antd, but it is miles better than what we've got now.

GabLeRoux · 2023-08-22T11:59:39Z

much better indeed!

EliasVal · 2023-08-22T15:39:30Z

Progress with tables :D
a lot of code is still commented out instead of removed since I'm still not done here. Left four TODO's in builds.tsx

- Reworked Starting/Opening Section - Began Working on pricing calculator - Changed JSX.Element (dep.) -> React.JSX.Element

EliasVal · 2023-08-22T20:43:50Z

Reworked Starting Section

Began work on "Pricing Calculator" (Concept):

- Created tooltip.tsx - Centered VSC buttons in Getting Started

- Moved GH, GL, CCI SVGs to /static/assets/images/icons - 'Finished' Devs that chose us section (more logos needed) - Reintroduced '.vscode' directory from .gitignore to support @apply rule

- Finished expandable menu - Only left to implement a Tooltip and DockerImageLinkOrRetryButton (will leave this one to webber)

EliasVal · 2023-08-26T13:38:45Z

:^)

webbertakken

Nice work!

Few minor comments.

webbertakken · 2023-09-02T18:40:23Z

Do you think it would be useful to use the existing approach for indicating when something happens based on an interaction? We already had toasts. I'm thinking we can keep the tooltip for the "click to copy" but then use the toast for the message "xyz copied to clipboard."

EliasVal · 2023-09-02T21:18:08Z

Do you think it would be useful to use the existing approach for indicating when something happens based on an interaction? We already had toasts. I'm thinking we can keep the tooltip for the "click to copy" but then use the toast for the message "xyz copied to clipboard."

Usure about this, I'll leave it to you. Also the ShowAndCopyChangeSetHashButton does not show up for me.

This reverts commit 62090d3.

Original author: https://github.com/EliasVal See game-ci#412

* Fix Versions page closes #410, credits to EliasVal <3 Original author: https://github.com/EliasVal See #412 * Replace icons with text for better dark and light theme * Remove extra lines and comments * Update completed emoji for better dark and light theme * Update fontSize for arrow icon in versions list

* chore: upgrade docusaurus / fix deprecations * chore: upgrade docusaurus / fix deprecations * feat: introduce v3 * chore: upgrade node in ci * Reconcile v2 and v3 docs with latest unity builder changes. Remove parameters not available in v2 from v2 docs. * Remove parameters and outputs from v2.2.0-pre * Update version tags to align with new version * chore: upgrade docusaurus tsconfig * chore: import/order * fix: unresolved import * chore: versions as client-side block * fix: firebase resolution * Re-enable sections, Prettier readme, use LF line endings * Upgraded getting-started.tsx - Upgraded getting-started.tsx to use company SVGs instead of text - Moved getting-started.tsx section up - Updated node16 references to node18 in .md files * Revamped versions page * INCOMPLETE: Changed out Ant's table * Starting Section Rework - Reworked Starting/Opening Section - Began Working on pricing calculator - Changed JSX.Element (dep.) -> React.JSX.Element * Created tooltip component - Created tooltip.tsx - Centered VSC buttons in Getting Started * Devs that chose us section - Moved GH, GL, CCI SVGs to /static/assets/images/icons - 'Finished' Devs that chose us section (more logos needed) - Reintroduced '.vscode' directory from .gitignore to support @apply rule * Docker versions progress - Finished expandable menu - Only left to implement a Tooltip and DockerImageLinkOrRetryButton (will leave this one to webber) * Tooltip & Docker Table finished * pricing section * disabled unused sections * resolved requests --------- Co-authored-by: Webber <webber@takken.io> Co-authored-by: Andrew Kahr <22359829+AndrewKahr@users.noreply.github.com> Co-authored-by: Gabriel Le Breton <lebreton.gabriel@gmail.com>

* Upgrade Homepage (#412) * chore: upgrade docusaurus / fix deprecations * chore: upgrade docusaurus / fix deprecations * feat: introduce v3 * chore: upgrade node in ci * Reconcile v2 and v3 docs with latest unity builder changes. Remove parameters not available in v2 from v2 docs. * Remove parameters and outputs from v2.2.0-pre * Update version tags to align with new version * chore: upgrade docusaurus tsconfig * chore: import/order * fix: unresolved import * chore: versions as client-side block * fix: firebase resolution * Re-enable sections, Prettier readme, use LF line endings * Upgraded getting-started.tsx - Upgraded getting-started.tsx to use company SVGs instead of text - Moved getting-started.tsx section up - Updated node16 references to node18 in .md files * Revamped versions page * INCOMPLETE: Changed out Ant's table * Starting Section Rework - Reworked Starting/Opening Section - Began Working on pricing calculator - Changed JSX.Element (dep.) -> React.JSX.Element * Created tooltip component - Created tooltip.tsx - Centered VSC buttons in Getting Started * Devs that chose us section - Moved GH, GL, CCI SVGs to /static/assets/images/icons - 'Finished' Devs that chose us section (more logos needed) - Reintroduced '.vscode' directory from .gitignore to support @apply rule * Docker versions progress - Finished expandable menu - Only left to implement a Tooltip and DockerImageLinkOrRetryButton (will leave this one to webber) * Tooltip & Docker Table finished * pricing section * disabled unused sections * resolved requests --------- Co-authored-by: Webber <webber@takken.io> Co-authored-by: Andrew Kahr <22359829+AndrewKahr@users.noreply.github.com> Co-authored-by: Gabriel Le Breton <lebreton.gabriel@gmail.com> * Fix deparated error * Fix logo issue in light mode and update HTML tag structure * Update HTML tag in dev section * Fix pricing section color and class name typo * Update css and optimize logo * Improve quality * Update code --------- Co-authored-by: Elias <46247153+EliasVal@users.noreply.github.com> Co-authored-by: Webber <webber@takken.io> Co-authored-by: Andrew Kahr <22359829+AndrewKahr@users.noreply.github.com> Co-authored-by: Gabriel Le Breton <lebreton.gabriel@gmail.com>

webbertakken and others added 14 commits August 16, 2023 22:25

chore: upgrade docusaurus / fix deprecations

e28fe87

chore: upgrade docusaurus / fix deprecations

bf117b5

feat: introduce v3

8e7759d

chore: upgrade node in ci

559876e

Reconcile v2 and v3 docs with latest unity builder changes. Remove pa…

0a577d0

…rameters not available in v2 from v2 docs.

Remove parameters and outputs from v2.2.0-pre

42d92bb

Update version tags to align with new version

ec071aa

chore: upgrade docusaurus tsconfig

9b50b9e

chore: import/order

90040fc

fix: unresolved import

f16ca3e

chore: versions as client-side block

816f0c2

fix: firebase resolution

6d80602

Merge branch 'main' into docs-v3

feb0b65

Re-enable sections, Prettier readme, use LF line endings

e6d9165

EliasVal added 3 commits August 22, 2023 02:44

Upgraded getting-started.tsx

a6a6f09

- Upgraded getting-started.tsx to use company SVGs instead of text - Moved getting-started.tsx section up - Updated node16 references to node18 in .md files

Revamped versions page

d6bdf16

Merge branch 'main' into upgrade_homepage

db70e9b

INCOMPLETE: Changed out Ant's table

1012ba3

Starting Section Rework

cffc100

- Reworked Starting/Opening Section - Began Working on pricing calculator - Changed JSX.Element (dep.) -> React.JSX.Element

EliasVal added 4 commits August 23, 2023 00:04

Created tooltip component

fdf11f3

- Created tooltip.tsx - Centered VSC buttons in Getting Started

Devs that chose us section

ef29646

- Moved GH, GL, CCI SVGs to /static/assets/images/icons - 'Finished' Devs that chose us section (more logos needed) - Reintroduced '.vscode' directory from .gitignore to support @apply rule

Docker versions progress

61f612f

- Finished expandable menu - Only left to implement a Tooltip and DockerImageLinkOrRetryButton (will leave this one to webber)

Tooltip & Docker Table finished

92596cf

EliasVal added 2 commits August 29, 2023 22:44

pricing section

a64dd3c

disabled unused sections

9c13a8b

webbertakken approved these changes Sep 2, 2023

View reviewed changes

resolved requests

73365ae

EliasVal requested a review from webbertakken September 2, 2023 21:20

webbertakken approved these changes Sep 7, 2023

View reviewed changes

Merge branch 'main' into upgrade_homepage

ff7be21

webbertakken merged commit 62090d3 into game-ci:main Sep 7, 2023

webbertakken added a commit that referenced this pull request Sep 26, 2023

Revert "Upgrade Homepage (#412)"

a132831

This reverts commit 62090d3.

webbertakken mentioned this pull request Sep 26, 2023

Revert "Upgrade Homepage" #424

Merged

webbertakken added a commit that referenced this pull request Sep 26, 2023

Revert "Upgrade Homepage (#412)" (#424)

f717e6d

This reverts commit 62090d3.

GabLeRoux added a commit to GabLeRoux/game-ci-documentation that referenced this pull request Oct 24, 2023

Fix Versions page closes game-ci#410, credits to EliasVal <3

510afa3

Original author: https://github.com/EliasVal See game-ci#412

GabLeRoux mentioned this pull request Oct 24, 2023

Fix Versions page closes #410, credits to EliasVal <3 #432

Merged

1 task

kathywklee mentioned this pull request Mar 25, 2024

Fix issues found when upgrading homepage #457

Merged

3 tasks

Uh oh!

Uh oh!

Conversation

EliasVal commented Aug 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Checklist

Uh oh!

github-actions Bot commented Aug 21, 2023

Uh oh!

EliasVal commented Aug 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

EliasVal commented Aug 22, 2023

Uh oh!

GabLeRoux commented Aug 22, 2023

Uh oh!

EliasVal commented Aug 22, 2023

Uh oh!

EliasVal commented Aug 22, 2023

Uh oh!

EliasVal commented Aug 26, 2023

Uh oh!

webbertakken left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

webbertakken commented Sep 2, 2023

Uh oh!

EliasVal commented Sep 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

EliasVal commented Aug 21, 2023 •

edited

Loading

EliasVal commented Aug 21, 2023 •

edited

Loading

EliasVal commented Sep 2, 2023 •

edited

Loading