Fix issues found when upgrading homepage#457
Merged
Merged
Conversation
* chore: upgrade docusaurus / fix deprecations * chore: upgrade docusaurus / fix deprecations * feat: introduce v3 * chore: upgrade node in ci * Reconcile v2 and v3 docs with latest unity builder changes. Remove parameters not available in v2 from v2 docs. * Remove parameters and outputs from v2.2.0-pre * Update version tags to align with new version * chore: upgrade docusaurus tsconfig * chore: import/order * fix: unresolved import * chore: versions as client-side block * fix: firebase resolution * Re-enable sections, Prettier readme, use LF line endings * Upgraded getting-started.tsx - Upgraded getting-started.tsx to use company SVGs instead of text - Moved getting-started.tsx section up - Updated node16 references to node18 in .md files * Revamped versions page * INCOMPLETE: Changed out Ant's table * Starting Section Rework - Reworked Starting/Opening Section - Began Working on pricing calculator - Changed JSX.Element (dep.) -> React.JSX.Element * Created tooltip component - Created tooltip.tsx - Centered VSC buttons in Getting Started * Devs that chose us section - Moved GH, GL, CCI SVGs to /static/assets/images/icons - 'Finished' Devs that chose us section (more logos needed) - Reintroduced '.vscode' directory from .gitignore to support @apply rule * Docker versions progress - Finished expandable menu - Only left to implement a Tooltip and DockerImageLinkOrRetryButton (will leave this one to webber) * Tooltip & Docker Table finished * pricing section * disabled unused sections * resolved requests --------- Co-authored-by: Webber <webber@takken.io> Co-authored-by: Andrew Kahr <22359829+AndrewKahr@users.noreply.github.com> Co-authored-by: Gabriel Le Breton <lebreton.gabriel@gmail.com>
|
|
webbertakken
approved these changes
Mar 25, 2024
webbertakken
left a comment
Member
There was a problem hiding this comment.
LGTM.
The pricing calculator could probably still be made to look more legit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR is to fix the issues found in #418.
To keep the changes small, this PR is more on making the page work.
Note: I am not able to reproduce the GameCI logo issue (first item in #418) as I can't use Safari. I believe it is not related to the #412 though.
Desktop:
GameCI.-.desktop.mp4
Mobile:
GameCI.-.mobile.mp4
Checklist
code of conduct