Skip to content

feat: introduce v3#407

Merged
webbertakken merged 13 commits into
mainfrom
docs-v3
Aug 22, 2023
Merged

feat: introduce v3#407
webbertakken merged 13 commits into
mainfrom
docs-v3

Conversation

@webbertakken

@webbertakken webbertakken commented Aug 16, 2023

Copy link
Copy Markdown
Member

Changes

  • Introduce v3

Also had to do a few other things to make it run smoothly

  • Upgrade TS and eslint resolver for TS
  • Upgrade Docusaurus to latest
  • Upgrade a few more packages
  • Update icon imports
  • Pin yarn and node version using Volta

Checklist

  • Read the contribution guide and accept the
    code of conduct
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

@github-actions

Copy link
Copy Markdown

Cat Gif

@github-actions

github-actions Bot commented Aug 16, 2023

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit feb0b65):

https://game-ci-5559f--pr407-docs-v3-c9uy6ad3.web.app

(expires Mon, 28 Aug 2023 19:47:15 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1f0574f15f83e11bfc148eae8646486a6d0e078b

@EliasVal

Copy link
Copy Markdown
Contributor

Looking into the Type check CI, maybe this should be able to fix the issue :)

@webbertakken

Copy link
Copy Markdown
Member Author

Looking into the Type check CI, maybe this should be able to fix the issue :)

Thanks @EliasVal!

@davidmfinol davidmfinol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GabLeRoux

Copy link
Copy Markdown
Member

Amazing work! 🎉

@GabLeRoux

Copy link
Copy Markdown
Member

I think this is currently blocked by the publication of v3 for unity-builder:
https://github.com/game-ci/unity-builder/releases

Will we also need to bump unity-test-runner?

@webbertakken

webbertakken commented Aug 21, 2023

Copy link
Copy Markdown
Member Author

I think this is currently blocked by the publication of v3 for unity-builder: https://github.com/game-ci/unity-builder/releases

Correct. I'm waiting for a review and then I'll double check and do the release

Will we also need to bump unity-test-runner?

Probably a good idea yea. We'll have to bump to 4 for the CLI integration anyway.

@webbertakken webbertakken merged commit e66ce4c into main Aug 22, 2023
@webbertakken webbertakken deleted the docs-v3 branch August 22, 2023 08:12
@webbertakken webbertakken mentioned this pull request Aug 22, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants