Re-land [shared_preferences] Add shared preferences devtool

[stuartmorgan-g]

Re-lands #8494 without changes, now that the unrelated failure is resolved. See #8515 for context.

[tarrinneal]

I said last time was the last time, but I'll make an exception one last time.

[adsonpleal]

@stuartmorgan, @kenzieschmoll, and @tarrinneal maybe not this time again 😬 .

Now we have a new issue.

There are files in the package directory that haven't been saved in git. Refusing to publish these files:

!! packages/shared_preferences/shared_preferences/.dart_tool/
!! packages/shared_preferences/shared_preferences/example/.dart_tool/
!! packages/shared_preferences/shared_preferences/example/.flutter-plugins
!! packages/shared_preferences/shared_preferences/example/.flutter-plugins-dependencies
!! packages/shared_preferences/shared_preferences/example/android/app/src/main/java/
!! packages/shared_preferences/shared_preferences/example/android/local.properties
!! packages/shared_preferences/shared_preferences/example/ios/Flutter/Generated.xcconfig
!! packages/shared_preferences/shared_preferences/example/ios/Flutter/ephemeral/
!! packages/shared_preferences/shared_preferences/example/ios/Flutter/flutter_export_environment.sh
!! packages/shared_preferences/shared_preferences/example/ios/Runner/GeneratedPluginRegistrant.h
!! packages/shared_preferences/shared_preferences/example/ios/Runner/GeneratedPluginRegistrant.m
!! packages/shared_preferences/shared_preferences/example/linux/flutter/ephemeral/
!! packages/shared_preferences/shared_preferences/example/linux/flutter/generated_plugin_registrant.cc
!! packages/shared_preferences/shared_preferences/example/linux/flutter/generated_plugin_registrant.h
!! packages/shared_preferences/shared_preferences/example/macos/Flutter/GeneratedPluginRegistrant.swift
!! packages/shared_preferences/shared_preferences/example/macos/Flutter/ephemeral/
!! packages/shared_preferences/shared_preferences/example/pubspec.lock
!! packages/shared_preferences/shared_preferences/example/windows/flutter/ephemeral/
!! packages/shared_preferences/shared_preferences/example/windows/flutter/generated_plugin_registrant.cc
!! packages/shared_preferences/shared_preferences/example/windows/flutter/generated_plugin_registrant.h
!! packages/shared_preferences/shared_preferences/extension/devtools/build/
!! packages/shared_preferences/shared_preferences/pubspec.lock

I guess this is happening because !! packages/shared_preferences/shared_preferences/extension/devtools/build/ is generated before the publish, which is the intended behavior.

The error is being thrown here. And failing because of this.

At first I thought this shouldn't happen, since we have this ignore. But git status is being run with a --ignored flag.

My guess is that we need to have a way to tell _checkGitStatus that it should ignore certain paths.

[stuartmorgan-g]

I've opened a revert, and am working on a fix to the tooling.

[stuartmorgan-g]

At first I thought this shouldn't happen, since we have this ignore. But git status is being run with a --ignored flag.

My guess is that we need to have a way to tell _checkGitStatus that it should ignore certain paths.

The fix is to just drop that flag. I believe it dates back to when pub publish didn't use .gitignore, so having extra files locally would pollute the published package.

[stuartmorgan-g]

The re-re-re-land successfully released! 🎉

[tarrinneal]

@adsonpleal https://www.youtube.com/watch?v=QUAItQmq-LU

[adsonpleal]

🚀 the best part is the commit name revert-8529-revert-8519-revert-8515-revert-8494-add-shared-preferences-devtool 😂

[adsonpleal]

FYK, I've just published a discontinuation notice for the standalone package.

[stuartmorgan-g]

🚀 the best part is the commit name revert-8529-revert-8519-revert-8515-revert-8494-add-shared-preferences-devtool 😂

It's definitely not not not not not a bad name!

[stuartmorgan-g]

More seriously, thanks for bearing with all the churn here. The auto-release mechanics are unfortunately one of the areas with the least pre-submit validation.